click

Merge lp://qastaging/~snappy-dev/click/lp1400308 into lp://qastaging/~snappy-dev/click/snappy

  1. lp1400308
  2. Merge into snappy
Proposed by Barry Warsaw
Status: Merged
Merge reported by: Michael Vogt
Merged at revision: not available
Proposed branch: lp://qastaging/~snappy-dev/click/lp1400308
Merge into: lp://qastaging/~snappy-dev/click/snappy
Diff against target: 96 lines (+49/-6)
2 files modified
click/build.py (+11/-2)
click/tests/test_build.py (+38/-4)
To merge this branch: bzr merge lp://qastaging/~snappy-dev/click/lp1400308
Reviewer Review Type Date Requested Status
Michael Vogt (community) Approve
James Hunt Pending
Snappy Developers Pending
Review via email: mp+244242@code.qastaging.launchpad.net

Description of the change

Fixes LP: #1400308 by complaining loudly (i.e. raising ClickBuildError) if the meta/readme.md file isn't just so. Remember that fp.readline() returns the empty string at EOF!

To post a comment you must log in.
Revision history for this message
Barry Warsaw (barry) wrote :

With tests! :)

Revision history for this message
Michael Vogt (mvo) wrote :

Thanks, looks good. I merged it and also fixed the parsing to of the paragraph in a seperate commit so this bug is done :)

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: