Merge lp://qastaging/~snwh/gnome-control-center-signon/high-contrast-icons into lp://qastaging/gnome-control-center-signon
Proposed by
Sam Hewitt
| Status: | Needs review | ||||
|---|---|---|---|---|---|
| Proposed branch: | lp://qastaging/~snwh/gnome-control-center-signon/high-contrast-icons | ||||
| Merge into: | lp://qastaging/gnome-control-center-signon | ||||
| Diff against target: |
120 lines (+28/-8) 1 file modified
Makefile.am (+28/-8) |
||||
| To merge this branch: | bzr merge lp://qastaging/~snwh/gnome-control-center-signon/high-contrast-icons | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Alberto Mardegan (community) | Needs Fixing | ||
|
Review via email:
|
|||
Description of the change
Online Accounts was missing an icon for the high contrast accessibility theme; icon was added to solve LP #1082097.
To post a comment you must log in.
Unmerged revisions
- 162. By Sam Hewitt
-
Added high contrast icons.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Thanks Sam for working on this. Your patch however doesn't work: the "HighContrast" icons are correctly added to the resulting debian package, but the "hicolor" ones don't get installed anymore.
I think this is due to changing the value of the "iconthemedir" variable on the fly; maybe using a variable with a different name could help.