Merge lp://qastaging/~snwh/landscape-client/high-contrast-icon into lp://qastaging/~landscape/landscape-client/trunk
Proposed by
Sam Hewitt
| Status: | Rejected | ||||
|---|---|---|---|---|---|
| Rejected by: | Dean Henrichsmeyer | ||||
| Proposed branch: | lp://qastaging/~snwh/landscape-client/high-contrast-icon | ||||
| Merge into: | lp://qastaging/~landscape/landscape-client/trunk | ||||
| Diff against target: |
163 lines (+68/-62) 4 files modified
debian/landscape-client-ui-install.install (+1/-0) icons/HighContrast/scalable/preferences-management-service.svg (+65/-0) icons/preferences-management-service.svg (+0/-62) setup.py (+2/-0) |
||||
| To merge this branch: | bzr merge lp://qastaging/~snwh/landscape-client/high-contrast-icon | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Geoff Teale (community) | Needs Fixing | ||
| Landscape | Pending | ||
|
Review via email:
|
|||
Description of the change
Landscape client was missing an icon for the high contrast accessibility theme; icon was added to solve LP #1082097.
To post a comment you must log in.
Revision history for this message
| Dean Henrichsmeyer (dean) wrote | # |
Unmerged revisions
- 694. By Sam Hewitt
-
Added high contrast icon; fixes LP 1082097
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Hi, thanks for helping out!
For me this branch seems to remove the old icon file and put the same icon in the HighContrast folder. I have 2 issues:
[1]. The old location of the icon file is still referred to in setup.py when setting it up for the hicolor icon theme.
[2]. It seems to be the same icon in HighContrast. It's quite contrasty so I guess that's OK, but wouldn't we fall back to that icon anyway if none were found in the HighContrast theme?