Simple Scan

Merge lp://qastaging/~soliloque/simple-scan/burst into lp://qastaging/~simple-scan-team/simple-scan/trunk

  1. burst
  2. Merge into trunk
Proposed by soliloque
Status: Merged
Merged at revision: 951
Proposed branch: lp://qastaging/~soliloque/simple-scan/burst
Merge into: lp://qastaging/~simple-scan-team/simple-scan/trunk
Diff against target: 124 lines (+47/-3)
3 files modified
data/simple-scan.ui (+29/-1)
src/scanner.vala (+10/-2)
src/ui.vala (+8/-0)
To merge this branch: bzr merge lp://qastaging/~soliloque/simple-scan/burst
Reviewer Review Type Date Requested Status
Robert Ancell Approve
Review via email: mp+321243@code.qastaging.launchpad.net

Commit message

Add burst mode scan type

Description of the change

As a simple-scan user, I routinely scan documents unfit for the charger because of binding or because it is made of thick paper. As of now, we must use the Single scan type and reach for the scan button for every page. This patch introduce a new scan type that use the flatbed, like Single, but run in burst mode, ie, after a scan is complete, it will automatically start another scan so we don't have to reach for the scan button but we can concentrate on putting the next page on the flatbed. This allow for faster, more pleasant, scanning.

To post a comment you must log in.
Revision history for this message
Robert Ancell (robert-ancell) wrote :

Great idea!

I've committed this with a few changes:
- Replaced some tab characters with spaces
- Renamed from burst to batch (seems the conventional name for this)
- Simplified a bit of the code.

I was wondering if it would be useful to have a configurable delay between scans in case you need more time to switch pages. What do you think?

Thanks!

review: Approve
Revision history for this message
soliloque (soliloque) wrote :

I think a configurable delay would be a nice addition. Let me send you a
new patch with this in a few days.

Have a nice day.

Le 2017-03-28 23:54, "Robert Ancell" <email address hidden> a écrit :

> Review: Approve
>
> Great idea!
>
> I've committed this with a few changes:
> - Replaced some tab characters with spaces
> - Renamed from burst to batch (seems the conventional name for this)
> - Simplified a bit of the code.
>
> I was wondering if it would be useful to have a configurable delay between
> scans in case you need more time to switch pages. What do you think?
>
> Thanks!
> --
> https://code.launchpad.net/~soliloque/simple-scan/burst/+merge/321243
> You are the owner of lp:~soliloque/simple-scan/burst.
>

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches