Merge ~soumyadghosh/mpv-snap:main into mpv-snap:main

Will add shaderc asap.

Hey there thanks for checking out, i have briefly checked this MR and here is my conclusion.

1) -1 from me for using the external ffmpeg content snap for now as i believe its just an extra 62 mb on the snap plus i believe it needs more time to get mature and get community attention, also having it under snapcrafters community etc. would have been desirable.

Currently i believe ffmpeg can be bundled with snap itself and i can overlook it although i do appreciate the incentive for a common ffmpeg-sdk for snaps.

2) Can you explain the patches you have applied ? I am generally not comfortable with downstream tweaking of upstream code as it just increases maintenance & responsibility overload and isn't desirable.

3) I do agree that we can drop reliance on mesa-content snap but i believe i will do it separately to let this MR remain open for consideration in the future.

4) Also the snap has screen-inhibit-plug already applied i am not sure what you meant to say in the 4th point, can you explain it a bit , i mean why the snapcraft plug won't work in gnome-wayland ?

https://git.launchpad.net/mpv-snap/tree/snapcraft.yaml?h=main#n56

5) I do agree that the mpris currently doesn't work in mpv as confirmed by playerctl, and hence i will look it ASAP in the future.

Overall this MR brings some hostile changes and hence needs more scrutiny.

P.S. I think this MR may also fit for celluloid snap too since it's also based upon mpv, maybe ?

2) It's the patch make to mpris work with the snap desktop file, as the desktop file name in the snap is not mpv but mpv_mpv just same as any other snap.

4) "This is needed because neither mpv supports GNOME's inhibition protocol, nor GNOME supports the standard inhibition protocol (yet)."
https://github.com/Guldoman/mpv_inhibit_gnome#mpv_inhibit_gnome

Hey there currently the mpris fix seems a must-fix, can you please create a new MR containing only the mpris related changes ?

P.S. Do ensure to avoid any other changes other than the mpris one so that i can fast-track its merge.

If a new MR can't be done, do care to DM me the patch.

Thanks. 🙂

> 2) It's the patch make to mpris work with the snap desktop file, as the
> desktop file name in the snap is not mpv but mpv_mpv just same as any other
> snap.
>
> 4) "This is needed because neither mpv supports GNOME's inhibition protocol,
> nor GNOME supports the standard inhibition protocol (yet)."
> https://github.com/Guldoman/mpv_inhibit_gnome#mpv_inhibit_gnome

👍

Regarding separate PR, I am sorry, but can't bother myself with that. It needs to build the mpris.so file from source. Kindly copy the patch from my repo, you have access to it as much I know.