Juju Charms Collection
vsm package

Merge lp://qastaging/~springfield-team/charms/precise/vsm/trunk into lp://qastaging/charms/vsm

  1. Precise Pangolin (12.04)
  2. trunk
  3. Merge into trunk
Proposed by Marga Millet
Status: Merged
Merged at revision: 32
Proposed branch: lp://qastaging/~springfield-team/charms/precise/vsm/trunk
Merge into: lp://qastaging/charms/vsm
Diff against target: 849 lines (+408/-131)
13 files modified
Makefile (+10/-0)
README.md (+41/-3)
config.yaml (+4/-6)
copyright (+1/-1)
hooks/config-changed (+159/-67)
hooks/install (+6/-31)
hooks/lib/common.sh (+1/-1)
hooks/lib/repackiso.py (+1/-21)
revision (+1/-0)
templates/vsm_vm.xml.tmpl (+6/-1)
test_requirements.txt (+7/-0)
tests/00_setup.sh (+17/-0)
tests/10_deploy_test.py (+154/-0)
To merge this branch: bzr merge lp://qastaging/~springfield-team/charms/precise/vsm/trunk
Reviewer Review Type Date Requested Status
Marco Ceppi (community) Approve
Jorge Niedbalski (community) Approve
Review via email: mp+232394@code.qastaging.launchpad.net

Description of the change

Added amulet test cases.

To post a comment you must log in.
lp://qastaging/~springfield-team/charms/precise/vsm/trunk updated
44. By Marga Millet

Added back the vsm input param validation

Revision history for this message
Jorge Niedbalski (niedbalski) wrote :

Marga,

Overall looks good, please generate the test_requirements.txt file with all the requirements for running the test suite.

Also, please create a 'testing' section on the README.md file pointing the instructions
for running the tests properly.

Also please make sure that your README.md files follows the markdown syntax ( https://help.github.com/articles/markdown-basics )

After getting this fixed, i will approve.

review: Needs Fixing
Revision history for this message
Jorge Niedbalski (niedbalski) wrote :

Please remove unused code from the charm.

review: Needs Fixing
lp://qastaging/~springfield-team/charms/precise/vsm/trunk updated
45. By Marga Millet

Changes from charm review comments

Revision history for this message
Marga Millet (millet) wrote :

I've pushed a new version (46) to the vsm trunk with all the changes from your review.

lp://qastaging/~springfield-team/charms/precise/vsm/trunk updated
46. By Marga Millet

Minor change in README.md

47. By Jorge Niedbalski

Added revision file

Revision history for this message
Jorge Niedbalski (niedbalski) wrote :

@millet

Thanks for fixing. Your overall changes looks pretty good.

LGTM +1

Subscribing to charmers for revision.

review: Approve
Revision history for this message
Marco Ceppi (marcoceppi) wrote :

LGTM! The addition of tests is fantastic.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: