Juju Charms Collection
vem package

Merge lp://qastaging/~springfield-team/charms/trusty/vem/next into lp://qastaging/charms/trusty/vem

  1. Trusty Tahr (14.04)
  2. next
  3. Merge into trunk
Proposed by Shiv Prasad Rao
Status: Work in progress
Proposed branch: lp://qastaging/~springfield-team/charms/trusty/vem/next
Merge into: lp://qastaging/charms/trusty/vem
Diff against target: 94 lines (+14/-10)
3 files modified
hooks/common.py (+8/-8)
hooks/config_changed.py (+2/-2)
metadata.yaml (+4/-0)
To merge this branch: bzr merge lp://qastaging/~springfield-team/charms/trusty/vem/next
Reviewer Review Type Date Requested Status
Antonio Rosales (community) community Needs Fixing
Review Queue (community) automated testing Needs Fixing
Jorge Niedbalski Pending
Edward Hope-Morley Pending
Review via email: mp+245232@code.qastaging.launchpad.net

This proposal supersedes a proposal from 2014-12-16.

Description of the change

Added new interface for nova-compute.

To post a comment you must log in.
Revision history for this message
Review Queue (review-queue) wrote : Posted in a previous version of this proposal

This items has failed automated testing! Results available here http://reports.vapour.ws/charm-tests/charm-bundle-test-10758-results

review: Needs Fixing (automated testing)
Revision history for this message
Jorge Niedbalski (niedbalski) wrote : Posted in a previous version of this proposal

Shiv, Could you review the latest automated testing results, there is a few lint and failing tests.

Please review this and i will merge as soon as is fixed.

review: Approve
Revision history for this message
Jorge Niedbalski (niedbalski) : Posted in a previous version of this proposal
review: Needs Fixing
Revision history for this message
Review Queue (review-queue) wrote :

This items has failed automated testing! Results available here http://reports.vapour.ws/charm-tests/charm-bundle-test-10821-results

review: Needs Fixing (automated testing)
Reply
Revision history for this message
Antonio Rosales (arosales) wrote :

Shiv,

Thanks for your contribution to the Juju Charm community, specifically to the VEM charm.

Per Jorge's comment and recent charm testing the charm is still failing make test:
http://reports.vapour.ws/charm-tests/charm-bundle-test-10821-results/charm/charm-testing-aws/2
ERROR: Failure: Exception (Please define the N1KV_SOURCE environment variable)

If you could help fix the N1KV_SOURCE error this will help validate your proposed changes.

-thanks,
Antonio

review: Needs Fixing (community)
Reply
Revision history for this message
Marco Ceppi (marcoceppi) wrote :

I've moved this merge to inprogress, please move the status "Needs review" when you'd like a follow up

Reply

Unmerged revisions

13. By Shiv Prasad Rao

Addressing lint issues

12. By Shiv Prasad Rao

adding interface for nova-compute relation

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches