Merge lp://qastaging/~ssweeny/friends/fix-lp1258657 into lp://qastaging/friends
Proposed by
Scott Sweeny
Status: | Merged |
---|---|
Approved by: | Robert Bruce Park |
Approved revision: | 253 |
Merged at revision: | 253 |
Proposed branch: | lp://qastaging/~ssweeny/friends/fix-lp1258657 |
Merge into: | lp://qastaging/friends |
Diff against target: |
22 lines (+3/-2) 1 file modified
friends/protocols/flickr.py (+3/-2) |
To merge this branch: | bzr merge lp://qastaging/~ssweeny/friends/fix-lp1258657 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Robert Bruce Park | Approve | ||
PS Jenkins bot (community) | continuous-integration | Approve | |
Review via email:
|
Commit message
Flickr: Fix oauth signing for a GET request.
According to [1] the base string for the OAuth signature must include all of the parameters, but oauthlib won't sign a GET request that includes a body. Instead pass the parameters as part of the URL.
Description of the change
Flickr: Fix oauth signing for a GET request.
According to [1] the base string for the OAuth signature must include all of the parameters, but oauthlib won't sign a GET request that includes a body. Instead pass the parameters as part of the URL.
To post a comment you must log in.
FAILED: Continuous integration, rev:253 /code.launchpad .net/~ssweeny/ friends/ fix-lp1258657/ +merge/ 206650/ +edit-commit- message
No commit message was specified in the merge proposal. Click on the following link and set the commit message (if you want a jenkins rebuild you need to trigger it yourself):
https:/
http:// jenkins. qa.ubuntu. com/job/ friends- ci/56/ jenkins. qa.ubuntu. com/job/ friends- trusty- amd64-ci/ 4
Executed test runs:
SUCCESS: http://
Click here to trigger a rebuild: s-jenkins. ubuntu- ci:8080/ job/friends- ci/56/rebuild
http://