Merge lp://qastaging/~stephen-elson/do-plugins/Dropbox into lp://qastaging/do-plugins

Added Dropbox plugin, features:

* Start & Stop actions - dependent on Dropbox daemon status.
* Web interface action - view folder in web interface (also works for Dropbox application item).
* Revisions action - view revisions of a Dropbox file in web interface.
* Link action - symlinks any file or folder to a user specified directory within Dropbox home. Returns the new file/folder item
* Share action - symlinks any file to "~/Dropbox/Public/Do Shared Items", randomising file name to prevent duplicates
* Unshare action - removes symlinks created with Share action

Possible performance issue - the Share/Unshare actions check all files in "Do Shared Files" for symlinks to file items during SupportsItem() testing. I could not think of a better way of doing this, but so far have not seen any actual performance problems.

I think I have followed the Mono coding guidelines, but I am sure some things have slipped through.

Thanks,
Steve

You forgot to add the DropboxAbstractAction.cs file

Hi Alex, sorry for the delay, I have been on holiday.
I've added the missing file, sorry about that.

I suggest to get a better quality dropbox icon, since the system default one seems only 16x16.

Here is one I found under cc license and looks great: http://vathanx.deviantart.com/art/Dropbox-Icon-106941298

I got an error while using the Get Public URL action:

Dropbox.DropboxPuburlAction "Get public URL" encountered an error in Perform: Index (zero based) must be greater than or equal to zero and less than the size of the argument list..

Plus, it seems when using "Add to Dropbox" action, the modifier item cannot be expanded to show sub-items.

Can you confirm what version of nautilus-dropbox and the dropboxd you have? You can see the dropboxd version number in the Dropbox preferences dialog, and the nautilus plugin via apt. I am running nautilus-dropbox 0.6.1 and dropboxd 0.6.510.

My version seems to have a 64x64 icon, which looks quite nice and I don't think needs replacing. The icons you linked to are quite nice, but are slightly different from the actual Dropbox brand, which might confuse users?

The Get Public URl error suggests you don't have the dropbox CLI script, I will add a check for this script and only offer actions that depend on it if it's present. This is also indicates you have an old version of dropbox, as the CLI was only made available in their last release.

I will investigate the issue with modifier items not being expandable.

OK, I have push an update which should fix the Get Public URL action, the plugin now only offers that action (and Start/Stop) if the dropbox CLI is present.

Still looking at the unexpandable modifier items, a bit stumped at the moment. Any suggestions here would be appreciated.

Thanks,
Steve

Now that I updated to the latest version of Dropbox, the issues I mentioned above are all gone.

I encountered another issue: after I share a file with non-ascii file name (Chinese) using the "Share with Dropbox" action, all actions will return an error message like:

    [Action's Name] encountered an error in SupportsItem: Argument is out of range..

It seems the exception happened just around the line

    if (link.HasContents && link.ContentsPath == target) {

inside DropboxAbstractAction.cs.

It might be an Mono issue.

Fixed that issue, seems like Mono.Unix.UnixSymbolicLinkInfo has trouble dealing with non-ascii characters in symlinks.
I am simply calling readlink instead now, which has reduced the dependencies for the plugin as well.

Still not sure why the modifier items are not expandable in Add to Dropbox, I think it could be an issue with the Files and Folders plugin? Maybe?

Hey Stephen,

I've just downloaded Dropbox and setup an account. Before I test the actual plugin, here are a few preliminary comments:
* Don't 'return null;' from an IEnumerable<T> Function (Like Perform ()). Use 'yield break;' instead.
* Use Path.Combine (from System.IO) to build directory paths. Don't do things like: 'home + "/Dropbox";'
* For IEnumerable<Type> SupportedItemTypes you don't need to create and return an array, simply use: 'yield return typeof (T);' for any types you need to return.
* For share & unshare actions, it would be nice to handle multiple items, instead of just using 'items.First ()'
This shouldn't be too hard, basically enclose everything in your perform action in a foreach (Item item in Items) { }
* This line from your Exec method on Dropbox.cs: "Log.Error ("Error running dropbox {0}: {2}", args, e.Message)", The 2 should be changed to a 1, I think.
* Also, for logging operations, use Log<Dropbox>.*, instead of Log.*

I'll branch the plugin and test out the actual actions too.

Thanks Chris,

I am just starting with C# (you could probably tell), so thanks very much for the tips :)

I will make those changes when I have time in the next few days.

Steve

Hi again,

actually, that didn't take long, I've just pushed a new version that should include all the changes you recommended. I look forward to hearing how your testing goes.

Steve

A couple more things I just thought of:

* Why did you make the dropbox class non static?
* You have hard-coded the paths to various folders, such as the dropbox folder, the do-shared folder. While installing Dropbox I noticed that you could change those paths, maybe it would be good to allow some sort of small configuration page to allow the user to select their dropbox folder, in case they have a setup that differs from the default.

Ah yes, the Dropbox class. That was slightly random I admit, I tried Log<Dropbox>.* but it complained about using a static class, so I just flipped it to non-static. I realised as I was doing it that is was a bit weird, but if you have a better suggestion for getting round the Log problem i'll happily revert it.

Folder locations - yep, I flagged this as a limitation over in the Google Group, and agree that a configuration page would be good. That might take a bit longer for me to do, I've never touched GTK before, but I'll make a start as soon as I can.

I'm pretty proficient with GTK# and could probably make a simple
config widget that would allow the user to set their dropbox folders
if you don't mind? If you'd like to learn GTK then by all means, feel
free, but I'm willing to help as well. It should be pretty simple,
I'm thinking just 1 or two text boxes that hold the folder path, maybe
a button to open the "choose folder" dialog box to make selecting a
path easy as well.

I think it's better to leave the Dropbox class static, there's no need
to create a new instance of it in each of your actions. I'll look
into the logging stuff w/ static classes. I know it's done with
Pidgin. Pidgin has a static class, but the Log<T> class is used
extensively in that plugin as well.

On Mon, Jun 1, 2009 at 1:24 AM, Stephen Elson<email address hidden> wrote:
> Ah yes, the Dropbox class. That was slightly random I admit, I tried Log<Dropbox>.* but it complained about using a static class, so I just flipped it to non-static. I realised as I was doing it that is was a bit weird, but if you have a better suggestion for getting round the Log problem i'll happily revert it.
>
> Folder locations - yep, I flagged this as a limitation over in the Google Group, and agree that a configuration page would be good. That might take a bit longer for me to do, I've never touched GTK before, but I'll make a start as soon as I can.
> --
> https://code.edge.launchpad.net/~stephen-elson/do-plugins/Dropbox/+merge/6440
> You are subscribed to branch lp:do-plugins.
>

I'd like to have a go, but would appreciate any advice you have. For
example, is there a similar config in the plugins repo that you'd suggest
I'd look at, and do you recommend a visual layout tool for building the
dialog? Basically, any tips on how to go about building it would be great.

If I get stuck or it's just taking too long, i'll take up your offer, I
appreciate you taking the interest :)

I'll revert the dropbox class and look at the Pidgin class for an idea of
how to do it better. In my defence i'd say that I did it quite late at night
after a very long and exhausting day!

Steve

The best way to add the configuration widget is to go into
monodevelop, and create a new file, select GTK as the type, then new
Widget. Look at some other plugins, (translate, pastebin) to see how
they added that widget. You'll need to have one of your actions or
itemsources implement the IConfigurable interface (part of
Do.Platform.Linux). From there, just design away with monodevelop's
gui builder. This will create a gtk-gui directory in your source dir,
make sure to include all of these files in Makefile.am. (The
gui.stetic file should be listed under the "RESOURCES" section, not
under the "FILES" section.)

I'm usually available in #gnome-do on freenode (nick: cszikszoy) if
you need help with anything.

On Mon, Jun 1, 2009 at 3:06 AM, Stephen Elson<email address hidden> wrote:
> I'd like to have a go, but would appreciate any advice you have. For
> example, is there a similar config in the plugins repo that you'd suggest
> I'd look at, and do you recommend a visual layout tool for building the
> dialog? Basically, any tips on how to go about building it would be great.
>
> If I get stuck or it's just taking too long, i'll take up your offer, I
> appreciate you taking the interest :)
>
> I'll revert the dropbox class and look at the Pidgin class for an idea of
> how to do it better. In my defence i'd say that I did it quite late at night
> after a very long and exhausting day!
>
> Steve
>
> --
> https://code.launchpad.net/~stephen-elson/do-plugins/Dropbox/+merge/6440
> You are subscribed to branch lp:do-plugins.
>

Hi,

I have added a configuration page that allows you to set the location of your Dropbox folder, with a default of ~/Dropbox. The "Do Shared Items" folder is another preference we could offer, but it *has* to be within the Dropbox/Public folder and I can't see a big advantage to offering it as configurable.

I have also tweaked the Dropbox class so it can be used in Log<Dropbox>. I used the Emesene plugin as a guide on how to do this.

Feedback welcome, especially on any noob mistakes in the GTK# code :)

This looks great. I installed the plugin today and tested it out and
everything seems to work very well. The GTK code is great. I don't
think we need anything more complicated than that.

One other thing I seemed to have missed is that all public strings
should use Catalog.GetString ("some string"). This creates the
translation contexts so we can translate the public strings into other
languages. Other than that, the plugin is great. Fix this and I'll
merge.

On Tue, Jun 2, 2009 at 1:54 PM, Stephen Elson<email address hidden> wrote:
> Hi,
>
> I have added a configuration page that allows you to set the location of your Dropbox folder, with a default of ~/Dropbox. The "Do Shared Items" folder is another preference we could offer, but it *has* to be within the Dropbox/Public folder and I can't see a big advantage to offering it as configurable.
>
> I have also tweaked the Dropbox class so it can be used in Log<Dropbox>. I used the Emesene plugin as a guide on how to do this.
>
> Feedback welcome, especially on any noob mistakes in the GTK# code :)
> --
> https://code.launchpad.net/~stephen-elson/do-plugins/Dropbox/+merge/6440
> You are subscribed to branch lp:do-plugins.
>

OK, I've committed those changes.
Thanks to you and Peng for all your help getting this plugin ready for merging :)

Steve

Hey Stephen,

DBO has fixed core to allow different filters for Items and Modifier Items. Can you change the code for the Link Action back to what it was before?

Here's a slightly modified copy I had to test with: http://paste.pocoo.org/show/121474/

Done :-)