Merge lp://qastaging/~stevanr/linaro-android-build-tools/drop-eula-generation into lp://qastaging/linaro-android-build-tools

Proposed by Stevan Radaković
Status: Merged
Approved by: Georgy Redkozubov
Approved revision: 600
Merged at revision: 598
Proposed branch: lp://qastaging/~stevanr/linaro-android-build-tools/drop-eula-generation
Merge into: lp://qastaging/linaro-android-build-tools
Diff against target: 83 lines (+12/-21)
6 files modified
build-scripts/BUILD-INFO_toolchain.txt (+7/-0)
build-scripts/build-android (+0/-13)
build-scripts/build-android-toolchain (+2/-2)
build-scripts/build-android-toolchain-linaro (+2/-2)
utils/mangle-jobs/builders.xml (+1/-1)
utils/mangle-jobs/push-artifacts-set.mangle (+0/-3)
To merge this branch: bzr merge lp://qastaging/~stevanr/linaro-android-build-tools/drop-eula-generation
Reviewer Review Type Date Requested Status
Georgy Redkozubov Approve
Review via email: mp+160053@code.qastaging.launchpad.net

Description of the change

Remove EULA/OPEN-EULA support.

To post a comment you must log in.
Revision history for this message
Georgy Redkozubov (gesha) wrote :

Stevan, there will be problem with toolchain builds because they don't have build-info.txt support, i.e. toolchain build doesn't generate BUILD-INFO.txt.
I guess we need to add 'open' BUILD-INFO.txt to build script directory and just copy it to the artifacts location.

599. By Stevan Radaković

Add open BUILD-INFO for toolchain builds.

Revision history for this message
Georgy Redkozubov (gesha) wrote :

I think it's better to say:
# Add BUILD-INFO.txt support
instead of
# Add open BUILD-INFO to replace OPEN-EULA

And copy BUILD-INFO_toolchain.txt to ../out/BUILD-INFO.txt

review: Needs Fixing
600. By Stevan Radaković

Fix dumb errors.

Revision history for this message
Georgy Redkozubov (gesha) wrote :

Looks good

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches