Merge lp://qastaging/~stevanr/linaro-ci-dashboard/fix_jenkins_dashboard_lib into lp://qastaging/linaro-ci-dashboard
Proposed by
Stevan Radaković
| Status: | Merged |
|---|---|
| Merged at revision: | 62 |
| Proposed branch: | lp://qastaging/~stevanr/linaro-ci-dashboard/fix_jenkins_dashboard_lib |
| Merge into: | lp://qastaging/linaro-ci-dashboard |
| Diff against target: |
87 lines (+32/-9) 3 files modified
dashboard/jenkinsserver/models/jenkins_server.py (+8/-2) dashboard/jenkinsserver/tests/test_jenkins_server.py (+18/-1) dashboard/lib/jenkins_dashboard.py (+6/-6) |
| To merge this branch: | bzr merge lp://qastaging/~stevanr/linaro-ci-dashboard/fix_jenkins_dashboard_lib |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Paul Sokolovsky | Approve | ||
| Georgy Redkozubov | Pending | ||
| Milo Casagrande | Pending | ||
|
Review via email:
|
|||
Description of the change
Fix exception handling for jenkins lib extension.
To post a comment you must log in.
Revision history for this message
| Paul Sokolovsky (pfalcon) wrote | # |
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
I would really suggest to use log.exception() in exception handlers - let's see what actual underlying error. Later, when we go into production mode, we can replace those which appear to frequently and don't represent real error with .info()/.warning() . But for time being ability to see real error which happens is a must imho.