Merge lp://qastaging/~steven.richards/kubuntu-docs/lucid into lp://qastaging/kubuntu-docs/lucid

Proposed by Steven Richards
Status: Needs review
Proposed branch: lp://qastaging/~steven.richards/kubuntu-docs/lucid
Merge into: lp://qastaging/kubuntu-docs/lucid
Diff against target: 587 lines (+80/-94)
14 files modified
docs/about/C/about.xml (+15/-16)
docs/audio/C/audio.xml (+9/-9)
docs/basics/C/basics.xml (+1/-1)
docs/bugs/C/bugs.xml (+8/-9)
docs/cli/C/cli.xml (+7/-1)
docs/communication/C/communication.xml (+14/-22)
docs/contact/C/contact.xml (+1/-1)
docs/contribute/C/contribute.xml (+9/-9)
docs/desktop/C/desktop.xml (+2/-2)
docs/games/C/games.xml (+1/-1)
docs/graphics/C/graphics.xml (+2/-2)
docs/netbook/C/netbook.xml (+2/-2)
docs/office/C/office.xml (+1/-1)
docs/welcome/C/welcome.xml (+8/-18)
To merge this branch: bzr merge lp://qastaging/~steven.richards/kubuntu-docs/lucid
Reviewer Review Type Date Requested Status
Nitesh Mistry (community) Needs Fixing
David Wonderly final review of lucid doc Pending
Review via email: mp+62933@code.qastaging.launchpad.net

Description of the change

Review of Lucid Kubuntu docs as ordered by david.wonderly

To post a comment you must log in.
Revision history for this message
Nitesh Mistry (mistrynitesh) wrote :

line #8 - IIRC, there was already a discussion about this quite sometime ago. The word "makes" is in regard to the word "team" which is singular and hence "makes" is appropriate.

line #20 - "Kubuntu" will be shown twice with this change.

line #21 - Changing from variable string to fixed string "Kubuntu" might not be appropriate.

line #47 - Just a typo - should be "piece" instead of "pieace"

line #61 - The comma after the word "Windows" is not required

lines #127 & 128 - I guess "&menuk3b;" does the same thing as suggested by Steven

line #209 - Just my opinion, but the word "similar" is more appropriate than "depicted" as it is possible that the user might see a little different dialogue box

line #331 - Again just my opinion, but the word "similar" is more appropriate than "close to".

lines #339-346 - Is that the place holder for the section on IRC? In that case, it would be inappropriate to delete them from the oneiric version right now as someone might take up writing that section.

line #363 - the "s" in "Services" should NOT be capital

line #373 - why is the word "and" not required?

line #472 - KDE games are not installed when installing Kubuntu using any installation media. That is why DVDRom is specifically mentioned and the next sentence differentiates between DVD and CD installation media.

line 494 - why comma after the word "text"?

lines #548-550 - why specific references to 10.04. The user might not have even seen 10.04 version.

line #573 - Again "Kubuntu" will be repeated in final output.

@Steven - Your attention to details is appreciated! :)

review: Needs Fixing
Revision history for this message
Steven Richards (steven.richards) wrote :

> line #8 - IIRC, there was already a discussion about this quite sometime ago.
> The word "makes" is in regard to the word "team" which is singular and hence
> "makes" is appropriate.
>
> line #20 - "Kubuntu" will be shown twice with this change.
>
> line #21 - Changing from variable string to fixed string "Kubuntu" might not
> be appropriate.
>
> line #47 - Just a typo - should be "piece" instead of "pieace"
>
> line #61 - The comma after the word "Windows" is not required
>
> lines #127 & 128 - I guess "&menuk3b;" does the same thing as suggested by
> Steven
>
> line #209 - Just my opinion, but the word "similar" is more appropriate than
> "depicted" as it is possible that the user might see a little different
> dialogue box
>
> line #331 - Again just my opinion, but the word "similar" is more appropriate
> than "close to".
>
> lines #339-346 - Is that the place holder for the section on IRC? In that
> case, it would be inappropriate to delete them from the oneiric version right
> now as someone might take up writing that section.
>
> line #363 - the "s" in "Services" should NOT be capital
>
> line #373 - why is the word "and" not required?
>
> line #472 - KDE games are not installed when installing Kubuntu using any
> installation media. That is why DVDRom is specifically mentioned and the next
> sentence differentiates between DVD and CD installation media.
>
> line 494 - why comma after the word "text"?
>
> lines #548-550 - why specific references to 10.04. The user might not have
> even seen 10.04 version.
>
> line #573 - Again "Kubuntu" will be repeated in final output.
>
> @Steven - Your attention to details is appreciated! :)

Hi Nitesh,

In regards to your comments, some of my edits are wrong but let me explain a few of your requests to fix:

#61,#373, #494, : Lists are done in the following format: X, Y, and Z. There is always a comma between and and the prior item in the list when there is 3 items. When it is more than three you do not use "and" and simply list: X, Y, Z, A, B.

#472 : I was mistaken as you can take the DVD Image as an ISO and flash it via a USB drive which would ideally be the same media.

#573, #20: Misread the line, whoops ;-)

#47: Typo, will fix, as for the rest I will also look into.

Thanks for your feedback

Unmerged revisions

182. By Steven Richards

Final revisions

181. By Steven Richards

Reviewed CLI page

180. By steven <steven@kubuntu>

Finished review and editing of bugs page

179. By steven <steven@kubuntu>

Fixed basics page

178. By Steven Richards

Fixed audio page

177. By Steven Richards

Fixed the About page

176. By Steven Richards

Welcome page patch

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches