Code review comment for lp://qastaging/~stevenk/launchpad/move-ifp-from-idistroseries

Revision history for this message
Jelmer Vernooij (jelmer) wrote :

Please add a docstring to InitialiseDistroSeries, perhaps based on the docstring for the original initialiseFromParent().

The module docstring of scripts/ftpmaster-tools/initialise-from-parent.py misses a tail dot.

I think the name InitialiseDistroSeries is a bit confusing (but the same applied to initialiseFromParent) as it suggests to me that it takes care of doing all of the initialization of the DistroSeries, not just the Soyuzy bits. I don't have any good suggestions, perhaps something like SetupDistroSeriesPackaging ?

review: Approve (code)

« Back to merge proposal