Drizzle

Merge lp://qastaging/~stewart/drizzle/bug716852-drizzle-prompt-doesnt-work into lp://qastaging/drizzle/7.0

  1. bug716852-drizzle-prompt-doesnt-work
  2. Merge into 7.0
Proposed by Stewart Smith
Status: Merged
Approved by: Brian Aker
Approved revision: 2156
Merged at revision: 2159
Proposed branch: lp://qastaging/~stewart/drizzle/bug716852-drizzle-prompt-doesnt-work
Merge into: lp://qastaging/drizzle/7.0
Diff against target: 15 lines (+4/-1)
1 file modified
client/drizzle.cc (+4/-1)
To merge this branch: bzr merge lp://qastaging/~stewart/drizzle/bug716852-drizzle-prompt-doesnt-work
Reviewer Review Type Date Requested Status
Olaf van der Spek (community) Needs Fixing
Drizzle Developers Pending
Review via email: mp+49352@code.qastaging.launchpad.net

Description of the change

found that --prompt at some point got broken, now it's fixed

To post a comment you must log in.
Revision history for this message
Olaf van der Spek (olafvdspek) wrote :

Why strdup?

review: Needs Fixing
Revision history for this message
Andrew Hutchings (linuxjedi) wrote :

I suspect a hang over from before the new sys_var processing was implemented. It can probably die now. I wouldn't be surprised to find similar things in that code though. All the drizzle clients will get an overhaul sometime after GA.

Revision history for this message
Stewart Smith (stewart) wrote :

On Fri, 11 Feb 2011 11:56:56 -0000, Olaf van der Spek <email address hidden> wrote:
> Review: Needs Fixing
> Why strdup?

as Andrew said - needs more work - this just fixes what was already there.

--
Stewart Smith

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches