Drizzle

Merge lp://qastaging/~stewart/drizzle/session_foo-functions-to-methods into lp://qastaging/drizzle/7.0

session_foo-functions-to-methods
Merge into 7.0

Proposed by Stewart Smith on 2011-02-09

Status:

Superseded

Proposed branch:

lp://qastaging/~stewart/drizzle/session_foo-functions-to-methods

Merge into:

lp://qastaging/drizzle/7.0

Diff against target:

458 lines (+62/-78)

11 files modified

drizzled/plugin.h (+0/-6)
drizzled/session.cc (+1/-34)
drizzled/session.h (+24/-1)
drizzled/statement/alter_table.cc (+3/-3)
plugin/archive/ha_archive.cc (+4/-4)
plugin/blitzdb/ha_blitz.cc (+2/-2)
plugin/filesystem_engine/filesystem_engine.cc (+3/-3)
plugin/haildb/haildb_engine.cc (+5/-5)
plugin/innobase/handler/ha_innodb.cc (+14/-14)
plugin/pbms/src/defs_ms.h (+3/-3)
plugin/pbxt/src/xt_defs.h (+3/-3)

To merge this branch:

bzr merge lp://qastaging/~stewart/drizzle/session_foo-functions-to-methods

Related bugs:

Bug #715539: (get\|set)_session_proc_info() still exists	Low	Fix Released
Bug #715575: misc session_foo() functions exist - should be methods in Session	Low	Fix Released

Link a bug report

Reviewer	Review Type	Date Requested	Status
Brian Aker		2011-02-09	Needs Fixing on 2011-02-09
Review via email: mp+49022@code.qastaging.launchpad.net

This proposal has been superseded by a proposal from 2011-02-10.

Description of the change

some encapsulation of some Session things that sholud be done properly C++ style and not the funny way that MySQL did to kinda-almost-but-not support C plugins.

http://hudson.drizzle.org/view/Drizzle-param/job/drizzle-param/734/

Revision history for this message

Brian Aker (brianaker) wrote on 2011-02-09:

Can you fix your methods to follow code style?

Thanks

review: Needs Fixing

lp://qastaging/~stewart/drizzle/session_foo-functions-to-methods updated on 2011-02-10

2157. By Stewart Smith on 2011-02-10: switch get_sql_command to getSqlCommand
2158. By Stewart Smith on 2011-02-10: fix Session::tx_isolation to be getTxIsolation to follow coding style, but look weird
2159. By Stewart Smith on 2011-02-10: switch doing_tablespace_operation to doingTablespaceOperation and set_doing_tablespace_operation to setDoingTablespaceOperation
2160. By Stewart Smith on 2011-02-10: switch doing_tablespace_operation to doingTablespaceOperation and set_doing_tablespace_operation to setDoingTablespaceOperation