Merge lp://qastaging/~stewart/percona-xtrabackup/2.0-basic-tests into lp://qastaging/percona-xtrabackup/2.0
Proposed by
Stewart Smith
| Status: | Work in progress |
|---|---|
| Proposed branch: | lp://qastaging/~stewart/percona-xtrabackup/2.0-basic-tests |
| Merge into: | lp://qastaging/percona-xtrabackup/2.0 |
| Diff against target: |
344 lines (+224/-31) 15 files modified
test/run.sh (+2/-1) test/t/basic.inc (+51/-0) test/t/basic_innodb_10_datafiles_small.sh (+3/-0) test/t/basic_innodb_2_datafiles.sh (+3/-0) test/t/basic_innodb_2_datafiles_small.sh (+3/-0) test/t/basic_innodb_datafiles_noautoextend.sh (+3/-0) test/t/basic_innodb_file_format_antelope.sh (+15/-0) test/t/basic_innodb_file_format_barracuda.sh (+16/-0) test/t/basic_innodb_file_per_table.sh (+3/-0) test/t/basic_skip_innodb_checksums.sh (+3/-0) test/t/basic_skip_innodb_doublewrite.sh (+3/-0) test/t/incremental.inc (+110/-0) test/t/incremental_skip_innodb_checksums.sh (+3/-0) test/t/incremental_skip_innodb_doublewrite.sh (+3/-0) test/t/xb_basic.sh (+3/-30) |
| To merge this branch: | bzr merge lp://qastaging/~stewart/percona-xtrabackup/2.0-basic-tests |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Alexey Kopytov (community) | Needs Fixing | ||
|
Review via email:
|
|||
Description of the change
This increases our test coverage of many simple situations with some server options set.
http://
To post a comment you must log in.
Unmerged revisions
- 477. By Stewart Smith
-
add some basic tests of xtrabackup alongside some commonly used innodb server options. Also do some basic incremental tests with some server options. This is a starting point for further, more exhaustive testing of XB and server options combinations
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
great starting point! some comments:
- innodb_file_format is also supported in 5.1 plugin, but the
"Required..." message says ">=5.5"
- unintentional line wrap in basic_innodb_
+${MYSQLD} --basedir=
+b-file-format
- but that does not result in a test failure due to "set +a". so it
just leads to an incorrect test skip:
http://
- checking for just innodb_file_format presence in "mysqld --help
--verbose" is insufficient to detect if Barracude is supported as a
file format. 5.1 plugin supports innodb_
not innodb_
- perhaps just looking at $INNODB_VERSION would be a better way to
check for supported formats? Something like:
: if [ -z "$INNODB_VERSION" ]; then
: ... antelope not supported
: fi
and
: if [[ $INNODB_VERSION < 1.1 ]]; then
: ... barracuda not supported
: fi
- shouldn't *.inc files go to the inc/ directory?
- since we now have incremental.inc, can other incremental test be
converted to use it?