stipple

Merge lp://qastaging/~stipple-devs/stipple/stipple-empathy into lp://qastaging/stipple

stipple-empathy
Merge into trunk

Proposed by Mitch Towner on 2010-07-23

Status:	Merged
Approved by:	malev on 2010-07-24
Approved revision:	18
Merged at revision:	18
Proposed branch:	lp://qastaging/~stipple-devs/stipple/stipple-empathy
Merge into:	lp://qastaging/stipple
Diff against target:	93 lines (+84/-0) 2 files modified plugins/empathy-accounts.py (+42/-0) plugins/empathy-logs.py (+42/-0)
To merge this branch:	bzr merge lp://qastaging/~stipple-devs/stipple/stipple-empathy
Related bugs:	Link a bug report

Reviewer	Date Requested	Status
Duane Hinnen		Approve on 2010-07-24
malev (community)	2010-07-23	Approve on 2010-07-24
Review via email: mp+30775@code.qastaging.launchpad.net

Description of the change

Added 2 separate plugins for empathy. 1 to sync account info, 1 to sync account logs. These 2 functions were originally combined into 1 plugin that didn't work due to a bug in the stipple.py code which is now fixed. Both Duane & I are undecided whether this functionality should be combined into 1 plugin or split into 2 different plugins.

The 'use case' for having 2 separate plugins is a user who wants to sync *only* their account info, not their conversation logs. Please feel free to comment with your thoughts.

Revision history for this message

malev (marcosvanetta) wrote on 2010-07-24:

I like it

review: Approve

Revision history for this message

Duane Hinnen (duanedesign) wrote on 2010-07-24:

Looks good. Will approve it. I think malev and I are starting to lean towards having it in one plugin. We will merge this branch and if we decide to combine them we can do it after the merge.

review: Approve

Revision history for this message

Shashank Sahni (shredder12) wrote on 2010-07-24:

I think providing the user with options is a good idea but splitting a plugin is not. What if we could use some form of nested check buttons for this purpose. Check this http://i27.tinypic.com/16kxtts.jpg. I am not sure if this could be done in gtk; searched but couldn't find anything. Or we can go for someother UI to let user select them. Adding two separate options will just clutter the interface. Perhaps stipple could use some UI improvements at this point to improve its capabilities.