Merge lp://qastaging/~stolowski/unity-lens-applications/download-app-preview-on-lmb into lp://qastaging/unity-lens-applications
Proposed by
Paweł Stołowski
| Status: | Rejected |
|---|---|
| Rejected by: | Michal Hruby |
| Proposed branch: | lp://qastaging/~stolowski/unity-lens-applications/download-app-preview-on-lmb |
| Merge into: | lp://qastaging/unity-lens-applications |
| Diff against target: |
29 lines (+3/-5) 2 files modified
src/daemon.vala (+1/-5) src/main.vala (+2/-0) |
| To merge this branch: | bzr merge lp://qastaging/~stolowski/unity-lens-applications/download-app-preview-on-lmb |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| PS Jenkins bot (community) | continuous-integration | Needs Fixing | |
| Michal Hruby | Pending | ||
|
Review via email:
|
|||
Commit message
Request preview on activation of unity-install:// uris.
Description of the change
Request preview on activation of unity-install:// uris.
To post a comment you must log in.
Revision history for this message
| Michal Hruby (mhr3) wrote | # |
Revision history for this message
| PS Jenkins bot (ps-jenkins) wrote | # |
review:
Needs Fixing
(continuous-integration)
Revision history for this message
| Michal Hruby (mhr3) wrote | # |
Unmerged revisions
- 296. By Paweł Stołowski
-
Set prgname of unity-applicati
ons-daemon. - 295. By Paweł Stołowski
-
Request preview on activation of unity-install:// uris.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Looking good, but dash doesn't behave well with this - the preview navigation is broken if standard activation returns a preview. Should be fixed in unity first.