Music Lens

Merge lp://qastaging/~stolowski/unity-lens-music/artwork-for-files-only into lp://qastaging/unity-lens-music

  1. artwork-for-files-only
  2. Merge into trunk
Proposed by Paweł Stołowski
Status: Merged
Approved by: Jussi Pakkanen
Approved revision: 110
Merged at revision: 109
Proposed branch: lp://qastaging/~stolowski/unity-lens-music/artwork-for-files-only
Merge into: lp://qastaging/unity-lens-music
Diff against target: 47 lines (+10/-4)
2 files modified
src/rhythmbox-collection.vala (+7/-4)
tests/unit/test-rhythmbox-parser.vala (+3/-0)
To merge this branch: bzr merge lp://qastaging/~stolowski/unity-lens-music/artwork-for-files-only
Reviewer Review Type Date Requested Status
Omer Akram (community) functional Approve
Jussi Pakkanen (community) Approve
Review via email: mp+125520@code.qastaging.launchpad.net

Commit message

Ignore iradio tag (radio stations) when parsing Rhythmbox database; check if track uri is a local file, this prevents unexpected network queries when radio stations are enabled back in the future.

Description of the change

Ignore iradio tag (radio stations) when parsing Rhythmbox database; check if track uri is a local file, this prevents unexpected network queries when radio stations are enabled back in the future.

To post a comment you must log in.
Revision history for this message
Paweł Stołowski (stolowski) wrote :

Please don't approve globally until Omer (originator of the bug) verifies it fixes the problem for him!

Revision history for this message
Omer Akram (om26er) wrote :

I created a new user account and the issue is 100% reproducible there for me and this branch actually fixes the problem but now songs without coverart look like this: http://ubuntuone.com/4e6tlFE5HKBAsmZZu5EV6W

review: Needs Fixing
Revision history for this message
Jussi Pakkanen (jpakkane) wrote :

Looks sensible to me. Approving with the assumption that the coverart issue above is either fixed or deemed not to be serious enough.

review: Approve
Revision history for this message
Paweł Stołowski (stolowski) wrote :

@Omer: two questions:
- did you compile music lens with --prefix=/usr ?
- do you have /usr/share/unity/6/album_missing.png (from unity-common package) on your system?

Revision history for this message
Omer Akram (om26er) wrote :

Its installed in /usr/local and /usr/share/unity/6/album_missing.png does exist.

Revision history for this message
Paweł Stołowski (stolowski) wrote :

> Its installed in /usr/local and /usr/share/unity/6/album_missing.png does
> exist.

You need to compile it with --prefix=/usr, otherwise it won't find album_missing.png (this icon is a recent addition); I think that's why you have broken icon if covert art is missing.

Revision history for this message
Omer Akram (om26er) wrote :

Then I guess we should merge this in as it clearly fixes the issue for me without any apparent regression.

Revision history for this message
Omer Akram (om26er) :
review: Approve (functional)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: