Merge lp://qastaging/~stolowski/unity-lens-music/banshee-previews into lp://qastaging/unity-lens-music
Proposed by
Paweł Stołowski
| Status: | Merged |
|---|---|
| Approved by: | Michal Hruby |
| Approved revision: | 111 |
| Merged at revision: | 111 |
| Proposed branch: | lp://qastaging/~stolowski/unity-lens-music/banshee-previews |
| Merge into: | lp://qastaging/unity-lens-music |
| Diff against target: |
274 lines (+206/-49) 1 file modified
src/banshee-scope.vala (+206/-49) |
| To merge this branch: | bzr merge lp://qastaging/~stolowski/unity-lens-music/banshee-previews |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Michal Hruby (community) | Approve | ||
|
Review via email:
|
|||
Commit message
Implemented support for banshee tracks/albums previews.
Description of the change
Implemented support for banshee tracks/albums previews.
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
148 + string[] split = uri.split ("/"); //FIXME: there must be more reliable way
149 + string artist = split[2];
150 + string title = split[3];
Looks somewhat crash-prone, could you add a check of the array length at least? (same around 219)