Merge lp://qastaging/~stolowski/unity-lens-music/codec-install into lp://qastaging/unity-lens-music

Proposed by Paweł Stołowski
Status: Merged
Approved by: Michal Hruby
Approved revision: 107
Merged at revision: 101
Proposed branch: lp://qastaging/~stolowski/unity-lens-music/codec-install
Merge into: lp://qastaging/unity-lens-music
Diff against target: 250 lines (+145/-10)
7 files modified
src/Makefile.am (+1/-0)
src/dash-proxy.vala (+48/-0)
src/main.vala (+2/-0)
src/music-preview-player.vala (+2/-0)
src/musicstore-daemon.vala (+2/-0)
src/player.vala (+70/-10)
tests/manual/previews-rhythmbox.txt (+20/-0)
To merge this branch: bzr merge lp://qastaging/~stolowski/unity-lens-music/codec-install
Reviewer Review Type Date Requested Status
Michal Hruby (community) Approve
Review via email: mp+122636@code.qastaging.launchpad.net

Commit message

Detect missing codecs and trigger their installation via gstreamer API.

Description of the change

Detect missing codecs and trigger their installation via gstreamer API.

Note: requires lp:~stolowski/unity/hide-dash-dbus-iface branch of Unity to hide dash via DBus call (will work without it, just dash won't get closed on codec installation).

To post a comment you must log in.
103. By Paweł Stołowski

Use GLib's warning/debug functions instead of stderr.

104. By Paweł Stołowski

Set prgname for music-preview-player

105. By Paweł Stołowski

Also set prgname of unity-music-daemon and unity-musicstore-daemon.

106. By Paweł Stołowski

Call HideDash() DBus method on codec installation.

Revision history for this message
Paweł Stołowski (stolowski) wrote :

Implemented dash hiding as discussed on IRC; requires lp:~stolowski/unity/hide-dash-dbus-iface Unity branch. Ready for re-review.

Revision history for this message
Michal Hruby (mhr3) wrote :

Looks fine, the name will need to be adapted though:

37 + static const string DASH_DBUS_NAME = "com.canonical.Unity.Dash";

107. By Paweł Stołowski

Use com.canonical.Unity name.

Revision history for this message
Michal Hruby (mhr3) wrote :

Great. +1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: