Music Lens

Merge lp://qastaging/~stolowski/unity-lens-music/unity-lens-music.preview-close into lp://qastaging/unity-lens-music

  1. unity-lens-music.preview-close
  2. Merge into trunk
Proposed by Paweł Stołowski
Status: Merged
Approved by: Michal Hruby
Approved revision: 99
Merged at revision: 93
Proposed branch: lp://qastaging/~stolowski/unity-lens-music/unity-lens-music.preview-close
Merge into: lp://qastaging/unity-lens-music
Diff against target: 142 lines (+49/-4)
5 files modified
src/music-preview-player.vala (+2/-2)
src/musicstore-scope.vala (+17/-0)
src/player-service.vala (+8/-2)
src/preview-player-client.vala (+6/-0)
src/rhythmbox-scope.vala (+16/-0)
To merge this branch: bzr merge lp://qastaging/~stolowski/unity-lens-music/unity-lens-music.preview-close
Reviewer Review Type Date Requested Status
Michal Hruby (community) Approve
Review via email: mp+120390@code.qastaging.launchpad.net

Commit message

Stop playback when preview is closed

Description of the change

Preview: implementation of 'closed' signal.

To post a comment you must log in.
Revision history for this message
Michal Hruby (mhr3) wrote :

As discussed on IRC, there are some races that come from the timeout that's used after calling GApplication.release()

review: Needs Fixing
lp://qastaging/~stolowski/unity-lens-music/unity-lens-music.preview-close updated
98. By Paweł Stołowski

Preview music player: call app.hold() on play() if app was released by stop(); also decreased
inactivity timeous to 300 msecs to minimize chances of races between stop and play.

99. By Paweł Stołowski

Preview player: after some discussions on IRC, increased inactivity timeout to 1 minute, so the music-preview-player is reused when
switching between previews. Race condition between play/close is very unlikely after all now.

Revision history for this message
Michal Hruby (mhr3) wrote :

Cool, let's get it in!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: