Unity Videos Lens

Merge lp://qastaging/~stolowski/unity-lens-video/preview-on-lmb into lp://qastaging/~unity-team/unity-lens-video/libunity7-compatible

preview-on-lmb
Merge into libunity7-compatible

Proposed by Paweł Stołowski on 2013-04-23

Status:

Merged

Approved by:

Martin Mrazik on 2013-04-24

Approved revision:

129

Merged at revision:

126

Proposed branch:

lp://qastaging/~stolowski/unity-lens-video/preview-on-lmb

Merge into:

lp://qastaging/~unity-team/unity-lens-video/libunity7-compatible

Diff against target:

99 lines (+23/-9)

3 files modified

configure.ac (+2/-2)
debian/control (+1/-1)
src/remote-scope.vala (+20/-6)

To merge this branch:

bzr merge lp://qastaging/~stolowski/unity-lens-video/preview-on-lmb

High

Fix Released

Link a bug report

Reviewer	Review Type	Date Requested	Status
PS Jenkins bot (community)	continuous-integration		Approve on 2013-04-24
Michal Hruby (community)		2013-04-23	Needs Fixing on 2013-04-24
Review via email: mp+160348@code.qastaging.launchpad.net

Commit message

Open preview on left-click for More Suggestions.

Description of the change

Open preview on left-click for More Suggestions.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2013-04-23:

PASSED: Continuous integration, rev:124
http://jenkins.qa.ubuntu.com/job/unity-team-unity-lens-video-libunity7-compatible-ci/6/
Executed test runs:
SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-team-unity-lens-video-libunity7-compatible-raring-amd64-ci/6

Click here to trigger a rebuild:
http://s-jenkins:8080/job/unity-team-unity-lens-video-libunity7-compatible-ci/6/rebuild

review: Approve (continuous-integration)

Revision history for this message

Michal Hruby (mhr3) wrote on 2013-04-23:

14 + if (rawuri.has_prefix ("https://videosearch.ubuntu.com"))
15 + return new Unity.ActivationResponse (Unity.HandledType.SHOW_PREVIEW);

This won't work, both "Online" and "More suggestions" results use this prefix.

review: Needs Fixing

lp://qastaging/~stolowski/unity-lens-video/preview-on-lmb updated on 2013-04-23

125. By Paweł Stołowski on 2013-04-23: Use activate_result handler added to libunity API to handle preview-on-activation based on category index.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2013-04-23:

FAILED: Continuous integration, rev:125
http://jenkins.qa.ubuntu.com/job/unity-team-unity-lens-video-libunity7-compatible-ci/7/
Executed test runs:
FAILURE: http://jenkins.qa.ubuntu.com/job/unity-team-unity-lens-video-libunity7-compatible-raring-amd64-ci/7/console

Click here to trigger a rebuild:
http://s-jenkins:8080/job/unity-team-unity-lens-video-libunity7-compatible-ci/7/rebuild

review: Needs Fixing (continuous-integration)

lp://qastaging/~stolowski/unity-lens-video/preview-on-lmb updated on 2013-04-24

126. By Paweł Stołowski on 2013-04-24: Put real category into metadata.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2013-04-24:

FAILED: Continuous integration, rev:126
http://jenkins.qa.ubuntu.com/job/unity-team-unity-lens-video-libunity7-compatible-ci/8/
Executed test runs:
FAILURE: http://jenkins.qa.ubuntu.com/job/unity-team-unity-lens-video-libunity7-compatible-raring-amd64-ci/8/console

Click here to trigger a rebuild:
http://s-jenkins:8080/job/unity-team-unity-lens-video-libunity7-compatible-ci/8/rebuild

review: Needs Fixing (continuous-integration)

lp://qastaging/~stolowski/unity-lens-video/preview-on-lmb updated on 2013-04-24

127. By Paweł Stołowski on 2013-04-24: Merged libunity-7 branch.
128. By Paweł Stołowski on 2013-04-24: Just store a bool in metadata to indiciate preview on LMB for more suggestions. Set schema.