Unity Videos Lens

Merge lp://qastaging/~stolowski/unity-lens-video/unity-lens-video.previews into lp://qastaging/unity-lens-video

unity-lens-video.previews
Merge into trunk

Proposed by Paweł Stołowski on 2012-08-08

Status:	Merged
Approved by:	Michal Hruby on 2012-08-15
Approved revision:	95
Merged at revision:	85
Proposed branch:	lp://qastaging/~stolowski/unity-lens-video/unity-lens-video.previews
Merge into:	lp://qastaging/unity-lens-video
Diff against target:	108 lines (+63/-1) 1 file modified src/unity-lens-video (+63/-1)
To merge this branch:	bzr merge lp://qastaging/~stolowski/unity-lens-video/unity-lens-video.previews
Related bugs:	Link a bug report

Reviewer	Date Requested	Status
Michal Hruby (community)	2012-08-08	Approve on 2012-08-15
Unity Videos lens	2012-08-08	Pending
Review via email: mp+118720@code.qastaging.launchpad.net

Commit message

Implementation of previews.

Description of the change

Initial implementation of previews.

lp://qastaging/~stolowski/unity-lens-video/unity-lens-video.previews updated on 2012-08-13

89. By Paweł Stołowski on 2012-08-13: Preview: require Gst/GstPbutils 1.0. Combined width, height info hints into "Dimensions" hint with aspect ratio.
90. By Paweł Stołowski on 2012-08-13: Preview: added 'Size' hint. Changed order of Format & Dimensions hints.
91. By Paweł Stołowski on 2012-08-13: Preview: use GLib.format_size function instead of custom one.

Revision history for this message

Michal Hruby (mhr3) wrote on 2012-08-14:

51 + while iter != end_iter:
52 + if model.get_value(iter, 0) == uri:

Linear iteration of the model :/ Not too nice, but hopefully it shouldn't be too much of an issue. s/get_value/get_string/

72 + preview.add_info(Unity.InfoHint.new("dimensions", "Dimensions", None, dimensions))

Please use gettext for the user-visible strings.

GLib.format_size(os.path.getsize(uri[7:]))))

Uris escape some characters, so they don't map exactly to path, this should be fixed.

87 + return Unity.ActivationResponse(goto_uri=uri, handled=2 )

Just because this is python doesn't make it ok to use numeric values for enums :) Anyway, you don't really need to connect to the activated signal here, the activation response will by default return NOT_HANDLED, so unity will run the default handler for the file.

review: Needs Fixing

lp://qastaging/~stolowski/unity-lens-video/unity-lens-video.previews updated on 2012-08-14

92. By Paweł Stołowski on 2012-08-14: Previews: properly handle uri when passing it to os.path.getsize().
Use is_last and get_string when iterating over dee model.
93. By Paweł Stołowski on 2012-08-14: Previews: added 'Show in folder' action for local videos.
94. By Paweł Stołowski on 2012-08-14: Previews: display modification time as subtitle.
95. By Paweł Stołowski on 2012-08-14: Previews: use gettext for user-visible strings.