Merge lp://qastaging/~stolowski/unity-scope-home/fix-1219911 into lp://qastaging/unity-scope-home
Proposed by
Paweł Stołowski
| Status: | Merged | ||||
|---|---|---|---|---|---|
| Approved by: | Michal Hruby | ||||
| Approved revision: | 160 | ||||
| Merged at revision: | 159 | ||||
| Proposed branch: | lp://qastaging/~stolowski/unity-scope-home/fix-1219911 | ||||
| Merge into: | lp://qastaging/unity-scope-home | ||||
| Diff against target: |
85 lines (+36/-6) 1 file modified
src/smart-scopes-preview-parser.vala (+36/-6) |
||||
| To merge this branch: | bzr merge lp://qastaging/~stolowski/unity-scope-home/fix-1219911 | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| PS Jenkins bot (community) | continuous-integration | Approve | |
| Michal Hruby (community) | Approve | ||
|
Review via email:
|
|||
Commit message
Properly handle info hints and subtitle when parsing previews from Smart Scopes Server. Don't print errors if 'attribution' is missing.
Description of the change
Properly handle info hints when parsing previews from Smart Scopes Server. Handle subtitle when parsing generic preview. Don't print errors if 'attribution' is missing.
To post a comment you must log in.
Revision history for this message
| PS Jenkins bot (ps-jenkins) wrote | # |
review:
Needs Fixing
(continuous-integration)
Revision history for this message
| PS Jenkins bot (ps-jenkins) | # |
review:
Approve
(continuous-integration)
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
LGTM