Unity Home Scope

Merge lp://qastaging/~stolowski/unity-scope-home/fix-cancellables into lp://qastaging/unity-scope-home

  1. fix-cancellables
  2. Merge into trunk
Proposed by Paweł Stołowski
Status: Merged
Approved by: Michal Hruby
Approved revision: 167
Merged at revision: 167
Proposed branch: lp://qastaging/~stolowski/unity-scope-home/fix-cancellables
Merge into: lp://qastaging/unity-scope-home
Diff against target: 40 lines (+2/-12)
1 file modified
src/scope.vala (+2/-12)
To merge this branch: bzr merge lp://qastaging/~stolowski/unity-scope-home/fix-cancellables
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Michal Hruby (community) Approve
Review via email: mp+186843@code.qastaging.launchpad.net

Commit message

Don't maintain own instances of cancellables. Use cancellable from search context.

To post a comment you must log in.
Revision history for this message
Michal Hruby (mhr3) wrote :

Looks good, fewer objects == better :)

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:167
http://jenkins.qa.ubuntu.com/job/unity-scope-home-ci/90/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-scope-home-saucy-amd64-ci/54
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-scope-home-saucy-armhf-ci/54
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-scope-home-saucy-i386-ci/54

Click here to trigger a rebuild:
http://s-jenkins:8080/job/unity-scope-home-ci/90/rebuild

review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: