Merge lp://qastaging/~stolowski/unity-scope-home/fix-metrics-warn into lp://qastaging/unity-scope-home
Proposed by
Paweł Stołowski
| Status: | Merged |
|---|---|
| Approved by: | Michal Hruby |
| Approved revision: | 111 |
| Merged at revision: | 111 |
| Proposed branch: | lp://qastaging/~stolowski/unity-scope-home/fix-metrics-warn |
| Merge into: | lp://qastaging/unity-scope-home |
| Diff against target: |
12 lines (+1/-1) 1 file modified
src/scope.vala (+1/-1) |
| To merge this branch: | bzr merge lp://qastaging/~stolowski/unity-scope-home/fix-metrics-warn |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Michal Hruby (community) | Approve | ||
| PS Jenkins bot (community) | continuous-integration | Approve | |
|
Review via email:
|
|||
Commit message
Take nullable session_id in handle_metrics to avoid misleading warnings.
Description of the change
Take nullable session_id in handle_metrics to avoid misleading warnings. Steps to repro (without the fix): open the dash with no search query, preview any of the items.
Note: it's not necessary to check session_id against null in handle_metrics, because session_id==null implies server_sid==null (and server_sid is checked).
To post a comment you must log in.
Revision history for this message
| PS Jenkins bot (ps-jenkins) wrote | # |
review:
Approve
(continuous-integration)
Revision history for this message
| Michal Hruby (mhr3) | # |
review:
Approve
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
PASSED: Continuous integration, rev:111
http://
Executed test runs:
SUCCESS: http://
Click here to trigger a rebuild:
http://