Unity Home Scope

Merge lp://qastaging/~stolowski/unity-scope-home/more-async into lp://qastaging/unity-scope-home

Proposed by Paweł Stołowski on 2013-03-26

Status:	Merged
Approved by:	Michal Hruby on 2013-03-26
Approved revision:	91
Merged at revision:	79
Proposed branch:	lp://qastaging/~stolowski/unity-scope-home/more-async
Merge into:	lp://qastaging/unity-scope-home
Diff against target:	159 lines (+69/-11) 2 files modified src/scope.vala (+68/-10) src/smart-scopes-more-suggestions-parser.vala (+1/-1)
To merge this branch:	bzr merge lp://qastaging/~stolowski/unity-scope-home/more-async
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
Michal Hruby (community)		2013-03-26	Approve on 2013-03-26
PS Jenkins bot (community)	continuous-integration		Approve on 2013-03-26
Review via email: mp+155535@code.qastaging.launchpad.net

Push remote data results to master scopes in an idle callback.

Push remote data results to master scopes in an idle callback.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2013-03-26:

review: Approve (continuous-integration)

84. By Paweł Stołowski on 2013-03-26: Minor fix.
85. By Paweł Stołowski on 2013-03-26: Don't mark more-suggestions results as 'personal'.
86. By Paweł Stołowski on 2013-03-26: Use more clear variables for async stuff in search method.
87. By Paweł Stołowski on 2013-03-26: Reset push_data_idle_src after removing the source.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2013-03-26:

review: Approve (continuous-integration)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2013-03-26:

review: Approve (continuous-integration)

Revision history for this message

Michal Hruby (mhr3) wrote on 2013-03-26:

49 + push_data.remove (scope_id);

Removing while iterating, not nice, can you use HashTableIter, push everything and do push_data.remove_all ()

review: Needs Fixing

88. By Paweł Stołowski on 2013-03-26: Use HashTableIter to iterate over push_data.
89. By Paweł Stołowski on 2013-03-26: Use remove_all after pushing the data.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2013-03-26:

review: Approve (continuous-integration)

90. By Paweł Stołowski on 2013-03-26: Declare scope_id/model unowned when iterating over push_data.
91. By Paweł Stołowski on 2013-03-26: s/message/debug.