Unity Home Scope

Merge lp://qastaging/~stolowski/unity-scope-home/more-logging into lp://qastaging/unity-scope-home

  1. more-logging
  2. Merge into trunk
Proposed by Paweł Stołowski
Status: Merged
Approved by: Michal Hruby
Approved revision: 81
Merged at revision: 78
Proposed branch: lp://qastaging/~stolowski/unity-scope-home/more-logging
Merge into: lp://qastaging/unity-scope-home
Diff against target: 102 lines (+23/-10)
2 files modified
src/main.vala (+13/-0)
src/scope.vala (+10/-10)
To merge this branch: bzr merge lp://qastaging/~stolowski/unity-scope-home/more-logging
Reviewer Review Type Date Requested Status
Michal Hruby (community) Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+155435@code.qastaging.launchpad.net

Commit message

Fixed conditional in smart scopes query callback that blocked it until local searches finish. Added custom log handler that prints timestamps (enabled only if HOME_SCOPE_VERBOSE is set, in additon to G_MESSAGES_DEBUG=all).

Description of the change

Fixed conditional in smart scopes query callback that blocked it until local searches finish. Added custom log handler that prints timestamps (enabled only if HOME_SCOPE_VERBOSE is set, in additon to G_MESSAGES_DEBUG=all).

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:79
http://jenkins.qa.ubuntu.com/job/unity-team-unity-scope-home-trunk-ci/34/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-team-unity-scope-home-trunk-raring-amd64-ci/34

Click here to trigger a rebuild:
http://s-jenkins:8080/job/unity-team-unity-scope-home-trunk-ci/34/rebuild

review: Approve (continuous-integration)
lp://qastaging/~stolowski/unity-scope-home/more-logging updated
80. By Paweł Stołowski

Include domain name in the output of custom logger.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:80
http://jenkins.qa.ubuntu.com/job/unity-team-unity-scope-home-trunk-ci/35/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-team-unity-scope-home-trunk-raring-amd64-ci/35

Click here to trigger a rebuild:
http://s-jenkins:8080/job/unity-team-unity-scope-home-trunk-ci/35/rebuild

review: Approve (continuous-integration)
Revision history for this message
Michal Hruby (mhr3) wrote :

10 + var now = new DateTime.now_utc ();

Can you do this instead, pls?

var time_val = TimeVal ();
string cur_time = time_val.to_iso8601 ().substring (11);

11 + stderr.printf ("%llu: %s\n", now.to_unix (), message);

Debug msgs should go to stdout.

review: Needs Fixing
lp://qastaging/~stolowski/unity-scope-home/more-logging updated
81. By Paweł Stołowski

Changed time formatting, use stdout in custom log handler.

Revision history for this message
Michal Hruby (mhr3) wrote :

+1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: