Merge lp://qastaging/~stolowski/unity-scope-home/more-previews into lp://qastaging/unity-scope-home

Proposed by Paweł Stołowski
Status: Merged
Approved by: Michal Hruby
Approved revision: 84
Merged at revision: 75
Proposed branch: lp://qastaging/~stolowski/unity-scope-home/more-previews
Merge into: lp://qastaging/unity-scope-home
Prerequisite: lp://qastaging/~stolowski/unity-scope-home/advanced-filters
Diff against target: 514 lines (+328/-50)
8 files modified
configure.ac (+1/-1)
src/Makefile.am (+1/-0)
src/markup-cleaner.vala (+108/-0)
src/scope.vala (+1/-1)
src/smart-scopes-preview-parser.vala (+52/-48)
src/smart-scopes-search.vala (+8/-0)
tests/unit/Makefile.am (+1/-0)
tests/unit/test-home-scope.vala (+156/-0)
To merge this branch: bzr merge lp://qastaging/~stolowski/unity-scope-home/more-previews
Reviewer Review Type Date Requested Status
Michal Hruby (community) Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+154988@code.qastaging.launchpad.net

Commit message

Handle actions for server previews. Handle music preview. Added MarkupCleaner (taken from shopping lens). Removed handles for preview types that we don't really expect, and use generic preview handler as a fallback. Added support for SMART_SCOPES_GEO_STORE environment variable to force geo_store parameter in search queries.

Description of the change

Handle actions for server previews. Handle music preview. Added MarkupCleaner (taken from shopping lens). Removed handles for preview types that we don't really expect, and use generic preview handler as a fallback. Added support for SMART_SCOPES_GEO_STORE environment variable to force geo_store parameter in search queries.

To post a comment you must log in.
83. By Paweł Stołowski

Bumped required version of libunity.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
84. By Paweł Stołowski

Fixed debug message.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Michal Hruby (mhr3) wrote :

Looks fine. +1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: