Merge lp://qastaging/~stolowski/unity-scope-home/reorder-delay into lp://qastaging/unity-scope-home

Proposed by Paweł Stołowski
Status: Merged
Approved by: Michal Hruby
Approved revision: 98
Merged at revision: 89
Proposed branch: lp://qastaging/~stolowski/unity-scope-home/reorder-delay
Merge into: lp://qastaging/unity-scope-home
Diff against target: 235 lines (+139/-8)
3 files modified
configure.ac (+3/-3)
src/scope.vala (+67/-5)
src/search-util.vala (+69/-0)
To merge this branch: bzr merge lp://qastaging/~stolowski/unity-scope-home/reorder-delay
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Michal Hruby (community) Approve
Review via email: mp+159323@code.qastaging.launchpad.net

This proposal supersedes a proposal from 2013-04-16.

Commit message

Improved category reordering and results flushing.

Description of the change

Experimenting with various ways to mitigate reordering.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote : Posted in a previous version of this proposal

FAILED: Continuous integration, rev:90
No commit message was specified in the merge proposal. Click on the following link and set the commit message (if you want a jenkins rebuild you need to trigger it yourself):
https://code.launchpad.net/~stolowski/unity-scope-home/reorder-delay/+merge/159135/+edit-commit-message

http://jenkins.qa.ubuntu.com/job/unity-scope-home-ci/6/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-scope-home-raring-amd64-ci/8/console

Click here to trigger a rebuild:
http://s-jenkins:8080/job/unity-scope-home-ci/6/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote : Posted in a previous version of this proposal

FAILED: Continuous integration, rev:91
No commit message was specified in the merge proposal. Click on the following link and set the commit message (if you want a jenkins rebuild you need to trigger it yourself):
https://code.launchpad.net/~stolowski/unity-scope-home/reorder-delay/+merge/159135/+edit-commit-message

http://jenkins.qa.ubuntu.com/job/unity-scope-home-ci/7/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-scope-home-raring-amd64-ci/9/console

Click here to trigger a rebuild:
http://s-jenkins:8080/job/unity-scope-home-ci/7/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote : Posted in a previous version of this proposal

FAILED: Continuous integration, rev:93
No commit message was specified in the merge proposal. Click on the following link and set the commit message (if you want a jenkins rebuild you need to trigger it yourself):
https://code.launchpad.net/~stolowski/unity-scope-home/reorder-delay/+merge/159135/+edit-commit-message

http://jenkins.qa.ubuntu.com/job/unity-scope-home-ci/8/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-scope-home-raring-amd64-ci/10/console

Click here to trigger a rebuild:
http://s-jenkins:8080/job/unity-scope-home-ci/8/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Michal Hruby (mhr3) wrote : Posted in a previous version of this proposal

34 + var reorder_time = Environment.get_variable ("HOME_SCOPE_REORDER_TIME"); //in milliseconds
35 + var flush_delay_ms_time = Environment.get_variable ("HOME_SCOPE_FLUSH_DELAY"); //in milliseconds
40 + category_reorder_time_ms = 1000;
45 + flush_delay_ms = 500;

Can you add consts for all of these? Plus move them to constructed(), constructor should have only the Object() call.

78 + var cat_reorder_timer = new SearchUtil.GLibSourceWrapper (GLib.Timeout.add (category_reorder_time_ms, () =>

Please change the signature of the Wrapper, so a source that was already removed will not be removed again.

97 + debug ("Transaction complete for scope %s, time = %s", scope_id, search_timer.elapsed ().to_string ());

"...time = %g"; no need to allocate extra strings just to print a double :)

95 + scope_search.transaction_complete.connect ((scope_id) =>

Pls disconnect the handler explicitly when it's no longer needed.

review: Needs Fixing
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote : Posted in a previous version of this proposal

FAILED: Continuous integration, rev:95
No commit message was specified in the merge proposal. Click on the following link and set the commit message (if you want a jenkins rebuild you need to trigger it yourself):
https://code.launchpad.net/~stolowski/unity-scope-home/reorder-delay/+merge/159135/+edit-commit-message

http://jenkins.qa.ubuntu.com/job/unity-scope-home-ci/9/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-scope-home-raring-amd64-ci/11

Click here to trigger a rebuild:
http://s-jenkins:8080/job/unity-scope-home-ci/9/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote : Posted in a previous version of this proposal

FAILED: Continuous integration, rev:96
No commit message was specified in the merge proposal. Click on the following link and set the commit message (if you want a jenkins rebuild you need to trigger it yourself):
https://code.launchpad.net/~stolowski/unity-scope-home/reorder-delay/+merge/159135/+edit-commit-message

http://jenkins.qa.ubuntu.com/job/unity-scope-home-ci/10/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-scope-home-raring-amd64-ci/12

Click here to trigger a rebuild:
http://s-jenkins:8080/job/unity-scope-home-ci/10/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Michal Hruby (mhr3) wrote : Posted in a previous version of this proposal

LGTM although we should do something about those warnings

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote : Posted in a previous version of this proposal
review: Approve (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:98
No commit message was specified in the merge proposal. Click on the following link and set the commit message (if you want a jenkins rebuild you need to trigger it yourself):
https://code.launchpad.net/~stolowski/unity-scope-home/reorder-delay/+merge/159323/+edit-commit-message

http://jenkins.qa.ubuntu.com/job/unity-scope-home-ci/12/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-scope-home-raring-amd64-ci/14

Click here to trigger a rebuild:
http://s-jenkins:8080/job/unity-scope-home-ci/12/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Michal Hruby (mhr3) :
review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: