Unity Home Scope

Merge lp://qastaging/~stolowski/unity-scope-home/reordering into lp://qastaging/unity-scope-home

  1. reordering
  2. Merge into trunk
Proposed by Paweł Stołowski
Status: Merged
Approved by: Michal Hruby
Approved revision: 98
Merged at revision: 81
Proposed branch: lp://qastaging/~stolowski/unity-scope-home/reordering
Merge into: lp://qastaging/unity-scope-home
Diff against target: 66 lines (+16/-3)
1 file modified
src/scope.vala (+16/-3)
To merge this branch: bzr merge lp://qastaging/~stolowski/unity-scope-home/reordering
Reviewer Review Type Date Requested Status
Michal Hruby (community) Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+155811@code.qastaging.launchpad.net

Commit message

Signal category order on finish of each scope search. Limit the number of recommendations that we take into consideration to 5.

Description of the change

Signal category order on finish of each scope search. Limit the number of recommendations that we take into consideration to 5.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:96
http://jenkins.qa.ubuntu.com/job/unity-team-unity-scope-home-trunk-ci/47/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-team-unity-scope-home-trunk-raring-amd64-ci/47

Click here to trigger a rebuild:
http://s-jenkins:8080/job/unity-team-unity-scope-home-trunk-ci/47/rebuild

review: Approve (continuous-integration)
lp://qastaging/~stolowski/unity-scope-home/reordering updated
97. By Paweł Stołowski

Only consider client-type scopes when cutting recommendations down.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:97
http://jenkins.qa.ubuntu.com/job/unity-team-unity-scope-home-trunk-ci/48/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-team-unity-scope-home-trunk-raring-amd64-ci/48

Click here to trigger a rebuild:
http://s-jenkins:8080/job/unity-team-unity-scope-home-trunk-ci/48/rebuild

review: Approve (continuous-integration)
lp://qastaging/~stolowski/unity-scope-home/reordering updated
98. By Paweł Stołowski

Renamed i to a more meaningful one.

Revision history for this message
Michal Hruby (mhr3) wrote :

I'd use 3 for the cutoff, but otherwise LGTM :)

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: