Code review comment for lp://qastaging/~stolowski/unity-scope-mediascanner/dont-pass-artist-by-search-string

Revision history for this message
Paweł Stołowski (stolowski) wrote :

This needs some more thought after all... It's not really about back button (which always leaves the scope and is only displayed when scope is not favorited) though.
After changing it to *not* abuse search string to pass artist name, it has an undesired side affect of not allowing user to go back to the scope's landing screen easily - in the existing code this can easily be done by tapping "X" in the search bar (which clears the artist name from search bar and goes back to the landing page of the scope). With this MP user has to select top-level department from the departments menu, which is not intuitive at all.

review: Needs Fixing

« Back to merge proposal