Unity Media Scanner Scope

Merge lp://qastaging/~stolowski/unity-scope-mediascanner/new-fallback-icon into lp://qastaging/unity-scope-mediascanner

  1. new-fallback-icon
  2. Merge into trunk
Proposed by Paweł Stołowski
Status: Merged
Approved by: Michi Henning
Approved revision: 299
Merged at revision: 306
Proposed branch: lp://qastaging/~stolowski/unity-scope-mediascanner/new-fallback-icon
Merge into: lp://qastaging/unity-scope-mediascanner
Diff against target: 214 lines (+176/-3)
3 files modified
src/mymusic/CMakeLists.txt (+2/-2)
src/mymusic/album_missing.svg (+173/-0)
src/mymusic/music-scope.cpp (+1/-1)
To merge this branch: bzr merge lp://qastaging/~stolowski/unity-scope-mediascanner/new-fallback-icon
Reviewer Review Type Date Requested Status
Michi Henning (community) Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+284867@code.qastaging.launchpad.net

Commit message

New fallback icon.

Description of the change

New fallback icon; haven't got reply about different icons for missing artist/album/song art, so sticking to single icon for now.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:297
http://jenkins.qa.ubuntu.com/job/unity-scope-mediascanner-ci/200/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-scope-mediascanner-vivid-amd64-ci/34
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-scope-mediascanner-vivid-armhf-ci/34
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-scope-mediascanner-vivid-i386-ci/34
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-scope-mediascanner-wily-amd64-ci/27
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-scope-mediascanner-wily-armhf-ci/27
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-scope-mediascanner-wily-i386-ci/27

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity-scope-mediascanner-ci/200/rebuild

review: Approve (continuous-integration)
lp://qastaging/~stolowski/unity-scope-mediascanner/new-fallback-icon updated
298. By Paweł Stołowski

Replace album_missing png icon with svg

Revision history for this message
James Henstridge (jamesh) wrote :

The artwork displays correctly with the thumbnailer changes in silo 45, but the new fallback art could do with a few tweaks:

http://imgur.com/a/xAx5j

In the list view, it looks like it could use a bit more padding so it isn't quite so close to the UbuntuShape surrounding it.

In the previews, it shows up as quite low res. Perhaps using the SVG version instead would help?

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:298
http://jenkins.qa.ubuntu.com/job/unity-scope-mediascanner-ci/201/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-scope-mediascanner-vivid-amd64-ci/35
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-scope-mediascanner-vivid-armhf-ci/35
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-scope-mediascanner-vivid-i386-ci/35
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-scope-mediascanner-wily-amd64-ci/28
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-scope-mediascanner-wily-armhf-ci/28
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-scope-mediascanner-wily-i386-ci/28

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity-scope-mediascanner-ci/201/rebuild

review: Approve (continuous-integration)
lp://qastaging/~stolowski/unity-scope-mediascanner/new-fallback-icon updated
299. By Paweł Stołowski

Updated the icon with more padding

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:299
http://jenkins.qa.ubuntu.com/job/unity-scope-mediascanner-ci/202/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-scope-mediascanner-vivid-amd64-ci/36
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-scope-mediascanner-vivid-armhf-ci/36
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-scope-mediascanner-vivid-i386-ci/36
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-scope-mediascanner-wily-amd64-ci/29
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-scope-mediascanner-wily-armhf-ci/29
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-scope-mediascanner-wily-i386-ci/29

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity-scope-mediascanner-ci/202/rebuild

review: Approve (continuous-integration)
Revision history for this message
Michi Henning (michihenning) wrote :

Looks good!

review: Approve
lp://qastaging/~stolowski/unity-scope-mediascanner/new-fallback-icon updated
300. By Paweł Stołowski

One more icon update from design

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: