Merge lp://qastaging/~stolowski/unity-scope-mediascanner/set-child-feeds into lp://qastaging/unity-scope-mediascanner

Proposed by Paweł Stołowski
Status: Merged
Approved by: Marcus Tomlinson
Approved revision: 208
Merged at revision: 219
Proposed branch: lp://qastaging/~stolowski/unity-scope-mediascanner/set-child-feeds
Merge into: lp://qastaging/unity-scope-mediascanner
Diff against target: 49 lines (+4/-2)
4 files modified
CMakeLists.txt (+1/-1)
debian/control (+1/-1)
src/musicaggregator/musicaggregator.ini.in (+1/-0)
src/videoaggregator/videoaggregator.ini.in (+1/-0)
To merge this branch: bzr merge lp://qastaging/~stolowski/unity-scope-mediascanner/set-child-feeds
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Needs Fixing
Pete Woods (community) Approve
Review via email: mp+239464@code.qastaging.launchpad.net

Commit message

Set ids of aggreated scopes via ChildScopes ini option.

Description of the change

Set ids of aggreated scopes via ChildScopes ini option.

To post a comment you must log in.
Revision history for this message
James Henstridge (jamesh) wrote :

FYI: This doesn't produce correct results for a CLICK_MODE=ON build (since the names of the local media scopes change).

Revision history for this message
Paweł Stołowski (stolowski) wrote :

> FYI: This doesn't produce correct results for a CLICK_MODE=ON build (since the
> names of the local media scopes change).
Ok, I added IDs of both normal and click-ified versions to the .ini file; one or the other will be unknown at runtime and ignored by the Shell. I think at the end we will need to come up with cleaner solution re these IDs since it will make it difficult in other areas as well (e.g. favorites)? Then we can also clean this one up.

208. By Paweł Stołowski

Add recently added child scopes to ChildScopes ini option.

Revision history for this message
Pete Woods (pete-woods) wrote :

Looks reasonable enough to me

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: