Merge lp://qastaging/~stolowski/unity-scope-mediascanner/support-artists into lp://qastaging/unity-scope-mediascanner
| Status: | Merged |
|---|---|
| Approved by: | Pete Woods |
| Approved revision: | 152 |
| Merged at revision: | 145 |
| Proposed branch: | lp://qastaging/~stolowski/unity-scope-mediascanner/support-artists |
| Merge into: | lp://qastaging/unity-scope-mediascanner |
| Diff against target: |
533 lines (+204/-57) 6 files modified
CMakeLists.txt (+2/-0) debian/control (+3/-0) src/music-scope.cpp (+152/-38) src/music-scope.h (+10/-2) src/musicaggregatorquery.cpp (+1/-1) tests/test-music-scope.cpp (+36/-16) |
| To merge this branch: | bzr merge lp://qastaging/~stolowski/unity-scope-mediascanner/support-artists |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| PS Jenkins bot (community) | continuous-integration | Approve | |
| Pete Woods (community) | Approve | ||
|
Review via email:
|
|||
Commit message
Implemented "Artists" department. Show photos of matching artists on search. Clicking an artist results goes into a 'fake' department, which shows large artist photo, biography and albums.
Introduce two new dependencies: net-cpp and jsoncpp.
Description of the change
Updated for final designs:
- implemented "Artists" department;
- show photos of matching artists on search;
- clicking an artist results goes into a 'fake' department, which shows large artist photo, biography and albums.
This MR introduces two new dependencies: net-cpp and jsoncpp.
Note: this branch needs the following to work properly:
* support for artist art in the thumbnailer
https:/
* don't requst previews for scope:// uris (just execute search):
https:/
| PS Jenkins bot (ps-jenkins) wrote | # |
| PS Jenkins bot (ps-jenkins) wrote | # |
| Pete Woods (pete-woods) | # |
| PS Jenkins bot (ps-jenkins) wrote | # |
| Pete Woods (pete-woods) | # |
| PS Jenkins bot (ps-jenkins) wrote | # |
FAILED: Continuous integration, rev:144
http://
Executed test runs:
FAILURE: http://
FAILURE: http://
FAILURE: http://
Click here to trigger a rebuild:
http://