unity-scopes-shell

Merge lp://qastaging/~stolowski/unity-scopes-shell/init-gettext into lp://qastaging/unity-scopes-shell

  1. init-gettext
  2. Merge into trunk
Proposed by Paweł Stołowski
Status: Merged
Approved by: Marcus Tomlinson
Approved revision: 269
Merged at revision: 272
Proposed branch: lp://qastaging/~stolowski/unity-scopes-shell/init-gettext
Merge into: lp://qastaging/unity-scopes-shell
Diff against target: 48 lines (+10/-3)
3 files modified
CMakeLists.txt (+2/-1)
src/Unity/localization.h (+5/-2)
src/Unity/plugin.cpp (+3/-0)
To merge this branch: bzr merge lp://qastaging/~stolowski/unity-scopes-shell/init-gettext
Reviewer Review Type Date Requested Status
Marcus Tomlinson (community) Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+275976@code.qastaging.launchpad.net

Commit message

Properly initialize gettext.

Description of the change

Properly initialize gettext. Embarassing... looks like we had translations support which never actually worked (and we never realized since there were no strings that needed it till now).

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:269
http://jenkins.qa.ubuntu.com/job/unity-scopes-shell-ci/399/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-scopes-shell-vivid-amd64-ci/93
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-scopes-shell-vivid-armhf-ci/93
        deb: http://jenkins.qa.ubuntu.com/job/unity-scopes-shell-vivid-armhf-ci/93/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-scopes-shell-vivid-i386-ci/93
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-scopes-shell-wily-amd64-ci/56
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-scopes-shell-wily-armhf-ci/56
        deb: http://jenkins.qa.ubuntu.com/job/unity-scopes-shell-wily-armhf-ci/56/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-scopes-shell-wily-i386-ci/56

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity-scopes-shell-ci/399/rebuild

review: Approve (continuous-integration)
Revision history for this message
Marcus Tomlinson (marcustomlinson) wrote :

Well yeah... my bad. Thanks for fixing this Pawel.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: