Merge lp://qastaging/~stolowski/unity/hide-dash-dbus-iface into lp://qastaging/unity

Proposed by Paweł Stołowski
Status: Merged
Approved by: Michal Hruby
Approved revision: no longer in the source branch.
Merged at revision: 2678
Proposed branch: lp://qastaging/~stolowski/unity/hide-dash-dbus-iface
Merge into: lp://qastaging/unity
Diff against target: 197 lines (+98/-1)
4 files modified
dash/DashController.cpp (+70/-0)
dash/DashController.h (+10/-0)
tests/autopilot/unity/emulators/dash.py (+9/-1)
tests/autopilot/unity/tests/test_dash.py (+9/-0)
To merge this branch: bzr merge lp://qastaging/~stolowski/unity/hide-dash-dbus-iface
Reviewer Review Type Date Requested Status
Michal Hruby (community) Approve
Review via email: mp+123271@code.qastaging.launchpad.net

Commit message

Implemented DBus interface for DashController and made HideDash() method available via DBus. Added autopilot test for it.
This is needed by music-preview-player codec installation functionality for hiding the dash when codec installation starts.

Description of the change

Implemented DBus interface for DashController and made HideDash() method available via DBus. Added autopilot test for it.
This is needed by music-preview-player codec installation functionality for hiding the dash when codec installation starts.

To post a comment you must log in.
Revision history for this message
Michal Hruby (mhr3) wrote :

9 +const std::string DBUS_NAME = "com.canonical.Unity.Dash";
148 + dash_object = session_bus.get_object('com.canonical.Unity.Dash',

I don't think we need to request yet another name for the dash, "com.canonical.Unity" (which is already used elsewhere in the code) is good enough.

review: Needs Fixing
Revision history for this message
Michal Hruby (mhr3) wrote :

40 + g_bus_get (G_BUS_TYPE_SESSION, nullptr, OnBusAcquired, this);

To be safe we should use a cancellable here and cancel the call in destructor.

review: Needs Fixing
Revision history for this message
Michal Hruby (mhr3) wrote :

Looking good now. +1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.