Merge lp://qastaging/~stub/charm-helpers/fix-configure_sources into lp://qastaging/charm-helpers
Proposed by
Stuart Bishop
| Status: | Merged | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Merged at revision: | 174 | ||||||||||||
| Proposed branch: | lp://qastaging/~stub/charm-helpers/fix-configure_sources | ||||||||||||
| Merge into: | lp://qastaging/charm-helpers | ||||||||||||
| Diff against target: |
83 lines (+37/-15) 2 files modified
charmhelpers/fetch/__init__.py (+23/-15) tests/fetch/test_fetch.py (+14/-0) |
||||||||||||
| To merge this branch: | bzr merge lp://qastaging/~stub/charm-helpers/fix-configure_sources | ||||||||||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Marco Ceppi | Approve | ||
| Jorge Niedbalski (community) | Approve | ||
|
Review via email:
|
|||
Description of the change
fetch.configure
Fix this. Also fix the docstring. And tests.
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
LGTM +1, the original code was broken with no config items. Also all your changes are covered by the submitted unit tests.
charmhelpers.fetch 95% 159, 294, 347-354
Thank you.