Merge lp://qastaging/~stub/charm-helpers/status-set into lp://qastaging/charm-helpers
Proposed by
Stuart Bishop
| Status: | Rejected |
|---|---|
| Rejected by: | Stuart Bishop |
| Proposed branch: | lp://qastaging/~stub/charm-helpers/status-set |
| Merge into: | lp://qastaging/charm-helpers |
| Diff against target: |
221 lines (+186/-4) 2 files modified
charmhelpers/core/hookenv.py (+68/-4) tests/core/test_hookenv.py (+118/-0) |
| To merge this branch: | bzr merge lp://qastaging/~stub/charm-helpers/status-set |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Stuart Bishop (community) | Disapprove | ||
|
Review via email:
|
|||
Description of the change
Wrap the new status-set and status-get hook tools, with fallback when running with versions of Juju that do not support the service status feature.
To post a comment you must log in.
Revision history for this message
| Stuart Bishop (stub) wrote | # |
Revision history for this message
| Stuart Bishop (stub) | # |
review:
Disapprove
Unmerged revisions
- 370. By Stuart Bishop
-
Wrap status-set and status-get, with fallback behavior for pre-service-status Juju
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The implicit termination causes trouble with the Config persistence feature, so that will need to be fixed. Or scrap this and go with https:/