Merge lp://qastaging/~stub/charms/precise/postgresql/bug-1187508-allowed-hosts into lp://qastaging/charms/postgresql

Proposed by Stuart Bishop
Status: Merged
Merged at revision: 57
Proposed branch: lp://qastaging/~stub/charms/precise/postgresql/bug-1187508-allowed-hosts
Merge into: lp://qastaging/charms/postgresql
Prerequisite: lp://qastaging/~stub/charms/precise/postgresql/charm-helpers
Diff against target: 52 lines (+13/-0)
2 files modified
README.markdown (+4/-0)
hooks/hooks.py (+9/-0)
To merge this branch: bzr merge lp://qastaging/~stub/charms/precise/postgresql/bug-1187508-allowed-hosts
Reviewer Review Type Date Requested Status
Marco Ceppi (community) Approve
Review via email: mp+174771@code.qastaging.launchpad.net

Description of the change

This is a resubmission of https://code.launchpad.net/~davidpbritton/charms/precise/postgresql/trunk/+merge/171906, conflicts resolved and suggestions implemented.

This is to address Bug #1187508, where a client charm has no way of knowing if the credentials it has will actually work for it yet.

Simple change to set and export an "allowed-units" relation setting. This will show if you can connect to the database or not. Since the relations run asynchronously, there is no way to determine this otherwise. If your host is in the allowed_host setting, your client IP has been added to the hba conf file.

To post a comment you must log in.
Revision history for this message
Stuart Bishop (stub) wrote :
Revision history for this message
David Britton (dpb) wrote :

Stub: looks great! thanks for re-implementing.

Revision history for this message
Marco Ceppi (marcoceppi) wrote :

LGTM +1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches