Merge lp://qastaging/~stub/charms/precise/postgresql/bug-1329816-backup-log-spurious-alert into lp://qastaging/charms/postgresql

Proposed by Stuart Bishop
Status: Merged
Merged at revision: 101
Proposed branch: lp://qastaging/~stub/charms/precise/postgresql/bug-1329816-backup-log-spurious-alert
Merge into: lp://qastaging/charms/postgresql
Prerequisite: lp://qastaging/~stub/charms/precise/postgresql/tests
Diff against target: 33 lines (+8/-1)
1 file modified
hooks/hooks.py (+8/-1)
To merge this branch: bzr merge lp://qastaging/~stub/charms/precise/postgresql/bug-1329816-backup-log-spurious-alert
Reviewer Review Type Date Requested Status
Michael Nelson (community) Approve
Review via email: mp+223210@code.qastaging.launchpad.net

Description of the change

The backup log file does not exist until the first backup runs, causing a spurious nagios alert on a freshly deployed service.

This branch ensures the log file is created on initial installation.

To post a comment you must log in.
Revision history for this message
Michael Nelson (michael.nelson) wrote :

Excellent - thanks Stuart!

review: Approve
142. By Stuart Bishop

revert unnecessary whitespace change

143. By Stuart Bishop

Merged tests into bug-1329816-backup-log-spurious-alert.

144. By Stuart Bishop

Merged tests into bug-1329816-backup-log-spurious-alert.

145. By Stuart Bishop

Merged tests into bug-1329816-backup-log-spurious-alert.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches