Juju Charms Collection
postgresql package

Merge lp://qastaging/~stub/charms/trusty/postgresql/fix-bsb into lp://qastaging/charms/trusty/postgresql

  1. Trusty Tahr (14.04)
  2. fix-bsb
  3. Merge into trunk
Proposed by Stuart Bishop
Status: Merged
Merged at revision: 141
Proposed branch: lp://qastaging/~stub/charms/trusty/postgresql/fix-bsb
Merge into: lp://qastaging/charms/trusty/postgresql
Diff against target: 113 lines (+49/-5)
2 files modified
hooks/storage.py (+26/-5)
tests/test_integration.py (+23/-0)
To merge this branch: bzr merge lp://qastaging/~stub/charms/trusty/postgresql/fix-bsb
Reviewer Review Type Date Requested Status
Review Queue (community) automated testing Approve
Björn Tillenius (community) Approve
Chris Glass Pending
Review via email: mp+282422@code.qastaging.launchpad.net

Description of the change

Fix the regressions in block storage broker external mounts.

Per Bug #1533502 and Bug #1533503, the request for disk was not being sent to the storage subordinate, and if it was, it would not do anything if an existing database was already in place. With this fixed, it again becomes possible to migrate PostgreSQL databases into fresh environments by remounting them on the new unit.

To post a comment you must log in.
lp://qastaging/~stub/charms/trusty/postgresql/fix-bsb updated
142. By Stuart Bishop

Fix tests

Revision history for this message
Björn Tillenius (bjornt) wrote :

I can't give an official +1, but the code looks good to me, and I've confirmed that it works with one postgresql unit having persistent storage. I haven't gotten it to work when two postgresql units are deployed, but it doesn't look like the postgresql charm is the blame for that.

review: Approve
Revision history for this message
Review Queue (review-queue) wrote :

This item has failed automated testing! Results available here http://juju-ci.vapour.ws:8080/job/charm-bundle-test-lxc/2173/

review: Needs Fixing (automated testing)
Revision history for this message
Review Queue (review-queue) wrote :

This item has failed automated testing! Results available here http://juju-ci.vapour.ws:8080/job/charm-bundle-test-aws/2154/

review: Needs Fixing (automated testing)
Revision history for this message
Review Queue (review-queue) wrote :

This item has failed automated testing! Results available here http://juju-ci.vapour.ws:8080/job/charm-bundle-test-lxc/2188/

review: Needs Fixing (automated testing)
Revision history for this message
Review Queue (review-queue) wrote :

This item has failed automated testing! Results available here http://juju-ci.vapour.ws:8080/job/charm-bundle-test-aws/2169/

review: Needs Fixing (automated testing)
Revision history for this message
Review Queue (review-queue) wrote :

The results (PASS) are in and available here: http://juju-ci.vapour.ws:8080/job/charm-bundle-test-lxc/2204/

review: Approve (automated testing)
Revision history for this message
Review Queue (review-queue) wrote :

The results (PASS) are in and available here: http://juju-ci.vapour.ws:8080/job/charm-bundle-test-aws/2186/

review: Approve (automated testing)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: