Launchpad itself

Merge lp://qastaging/~stub/launchpad/db-stats into lp://qastaging/launchpad/db-devel

  1. db-stats
  2. Merge into db-devel
Proposed by Stuart Bishop
Status: Merged
Approved by: Robert Collins
Approved revision: no longer in the source branch.
Merged at revision: 9568
Proposed branch: lp://qastaging/~stub/launchpad/db-stats
Merge into: lp://qastaging/launchpad/db-devel
Diff against target: 175 lines (+78/-22)
2 files modified
lib/lp/scripts/helpers.py (+2/-1)
utilities/report-database-stats.py (+76/-21)
To merge this branch: bzr merge lp://qastaging/~stub/launchpad/db-stats
Reviewer Review Type Date Requested Status
Robert Collins (community) Approve
Jelmer Vernooij (community) Abstain
Review via email: mp+28713@code.qastaging.launchpad.net

Commit message

Allow report-database-stats.py to generate reports over arbitrary time frames.

Description of the change

Allow report-database-stats.py to generate reports over arbitrary time frames. Currently it just reports on a period up until now.

To post a comment you must log in.
Revision history for this message
Jelmer Vernooij (jelmer) wrote :

Not actively reviewing this at the moment.

review: Abstain
Revision history for this message
Robert Collins (lifeless) wrote :

8 - TYPES = Option.TYPES + ("datetime",)
9 + TYPES = Option.TYPES + ("datetime", datetime)

is odd

doing string clause generation rather than storm expressions is suboptimal but ok in this context I guess given the existing code.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to status/vote changes: