Merge lp://qastaging/~suutari-olli/openlp/new-icons-for-preview-and-replace-live-bg into lp://qastaging/openlp
| Status: | Merged |
|---|---|
| Approved by: | Tim Bentley |
| Approved revision: | 2635 |
| Merged at revision: | 2640 |
| Proposed branch: | lp://qastaging/~suutari-olli/openlp/new-icons-for-preview-and-replace-live-bg |
| Merge into: | lp://qastaging/openlp |
| Diff against target: |
135704 lines (+67703/-67687) 3 files modified
openlp/core/resources.py (+67701/-67685) openlp/plugins/images/lib/mediaitem.py (+1/-1) openlp/plugins/media/lib/mediaitem.py (+1/-1) |
| To merge this branch: | bzr merge lp://qastaging/~suutari-olli/openlp/new-icons-for-preview-and-replace-live-bg |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Tim Bentley | Approve | ||
| Raoul Snyman | Approve | ||
|
Review via email:
|
|||
This proposal supersedes a proposal from 2016-04-03.
Description of the change
Added new icon for Preview. (Provided by superfly)
-------
This branch changes icons for Preview and Replace Live background buttons.
Currently preview button uses same icon as Blank to Theme and
Replace Live background uses same icon as Blank to black.
This is problematic because these icons don’t describe these
actions and may be confused with their other meanings.
Preview icon is replaced by system_
frame and is easily distinguishable from blank to icons.
Replace Live background icon now uses Blank to theme icon.
I feel like this describes it much better than “Blank to black”
lp:~suutari-olli/openlp/new-icons-for-preview-and-replace-live-bg
(revision 2633)
[←[1;32mSUCCESS
[←[1;32mSUCCESS
[←[1;32mSUCCESS
[←[1;32mSUCCESS
[←[1;32mSUCCESS
[←[1;32mSUCCESS
[←[1;32mSUCCESS
| Raoul Snyman (raoul-snyman) | # |
| Tim Bentley (trb143) | # |
