A SYLEAM Component - OpenObject Library

Merge lp://qastaging/~syleam/openobject-library/fix_dash_split_bug into lp://qastaging/openobject-library/1.0

  1. fix_dash_split_bug
  2. Merge into 1.0
Proposed by Sylvain Garancher
Status: Needs review
Proposed branch: lp://qastaging/~syleam/openobject-library/fix_dash_split_bug
Merge into: lp://qastaging/openobject-library/1.0
Diff against target: 21 lines (+2/-2)
1 file modified
example/importcsv.py (+2/-2)
To merge this branch: bzr merge lp://qastaging/~syleam/openobject-library/fix_dash_split_bug
Reviewer Review Type Date Requested Status
Christophe CHAUVET Disapprove
Review via email: mp+117435@code.qastaging.launchpad.net

Description of the change

Fixes the bug on Windows operating system when splitting a path which contains dashes on importcsv script

To post a comment you must log in.
Revision history for this message
Christophe CHAUVET (christophe-chauvet) wrote :

Hi Sylvain

I prefer you use "os.sep" [1] to find the separator from teh operating system

Please fix and resubmit

Regards,

[1] : http://docs.python.org/release/2.6.8/library/os.html?highlight=os#os.sep

review: Disapprove
Reply
Revision history for this message
Niels Huylebroeck (red15) wrote :

It's worth checking out this function to see if it can properly handle the splitting of paths as well:

http://docs.python.org/release/2.6.8/library/os.path.html#os.path.split

Mind the caveat that paths ending in '/' (or '\') will not produce a tail return value.

Reply

Unmerged revisions

107. By Sylvain Garancher

[FIX] Fixed dash split bug on directories names under Windows operating system

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches