Checkbox

Merge lp://qastaging/~sylvain-pineau/checkbox/build_dep_80211_resource into lp://qastaging/~checkbox-dev/checkbox/checkbox-packaging

  1. build_dep_80211_resource
  2. Merge into checkbox-packaging
Proposed by Zygmunt Krynicki
Status: Merged
Approved by: Zygmunt Krynicki
Approved revision: 57
Merged at revision: 55
Proposed branch: lp://qastaging/~sylvain-pineau/checkbox/build_dep_80211_resource
Merge into: lp://qastaging/~checkbox-dev/checkbox/checkbox-packaging
Diff against target: 22 lines (+3/-2)
1 file modified
debian/control (+3/-2)
To merge this branch: bzr merge lp://qastaging/~sylvain-pineau/checkbox/build_dep_80211_resource
Reviewer Review Type Date Requested Status
Zygmunt Krynicki (community) Approve
Daniel Manrique Pending
Sylvain Pineau Pending
Review via email: mp+203445@code.qastaging.launchpad.net

This proposal supersedes a proposal from 2014-01-27.

Description of the change

Add the libnl-genl-3-dev build dependency (required to build 80211_resource)

To post a comment you must log in.
Revision history for this message
Daniel Manrique (roadmr) wrote : Posted in a previous version of this proposal

Does libnl3-genl-dev also depend on libnl3-dev? if not, maybe it's worth adding it as a separate dependency.

Also, maybe we need the run-time dependency on the binary package, even if it's installed by default on Ubuntu I'd prefer to explicitly state that we need it.

review: Needs Information
Revision history for this message
Sylvain Pineau (sylvain-pineau) wrote : Posted in a previous version of this proposal

Yes it depends on libnl-3-dev: http://packages.ubuntu.com/fr/trusty/libnl-genl-3-dev

I'll add the runtime dependency, good idea. thanks

Revision history for this message
Sylvain Pineau (sylvain-pineau) wrote : Posted in a previous version of this proposal

Added a runtime dep on libnl-genl-3-200 (itself depending on libnl-3-200, see http://packages.ubuntu.com/fr/trusty/libnl-genl-3-200)

review: Needs Resubmitting
Revision history for this message
Daniel Manrique (roadmr) wrote : Posted in a previous version of this proposal

Thanks so much! Approving now.

review: Approve
Revision history for this message
Daniel Manrique (roadmr) wrote : Posted in a previous version of this proposal

No proposals found for merge of lp:~sylvain-pineau/checkbox/80211_resource into lp:~checkbox-dev/checkbox/checkbox-packaging.

Revision history for this message
Daniel Manrique (roadmr) wrote : Posted in a previous version of this proposal

whaat ;)

review: Approve
Revision history for this message
Sylvain Pineau (sylvain-pineau) wrote : Posted in a previous version of this proposal

approved, run tarmac, run

review: Approve
Revision history for this message
Zygmunt Krynicki (zyga) wrote : Posted in a previous version of this proposal

"run luke, run" ;-)

Revision history for this message
Daniel Manrique (roadmr) wrote : Posted in a previous version of this proposal

No proposals found for merge of lp:~sylvain-pineau/checkbox/80211_resource into lp:~checkbox-dev/checkbox/checkbox-packaging.

Revision history for this message
Daniel Manrique (roadmr) wrote : Posted in a previous version of this proposal

OHHH, so you can't depend on a branch if the merge target for that branch is not the same as this one :(

Could you please supersede this MR with another one removing the prerequisite? And please self-approve that to expedite things. The prerequisite is already merged.

Revision history for this message
Zygmunt Krynicki (zyga) wrote :

Approving without the prerequisite branch

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches