Merge lp://qastaging/~sylvain-pineau/checkbox/canonical-certification-server-packaging into lp://qastaging/~checkbox-dev/checkbox/checkbox-packaging

Proposed by Sylvain Pineau
Status: Merged
Approved by: Zygmunt Krynicki
Approved revision: 30
Merged at revision: 26
Proposed branch: lp://qastaging/~sylvain-pineau/checkbox/canonical-certification-server-packaging
Merge into: lp://qastaging/~checkbox-dev/checkbox/checkbox-packaging
Diff against target: 94 lines (+35/-1)
6 files modified
debian/canonical-certification-server.install (+1/-0)
debian/checkbox-ng.install (+1/-0)
debian/control (+28/-0)
debian/python3-checkbox-ng.install (+1/-0)
debian/python3-plainbox.install (+1/-1)
debian/rules (+3/-0)
To merge this branch: bzr merge lp://qastaging/~sylvain-pineau/checkbox/canonical-certification-server-packaging
Reviewer Review Type Date Requested Status
Zygmunt Krynicki (community) Approve
Sylvain Pineau (community) Needs Resubmitting
Review via email: mp+192860@code.qastaging.launchpad.net

Description of the change

New canonical-certification-server packaging:

- declaration in debian/control
- Added checkbox-ng in debian/rules
- and the corresponding .install file

To post a comment you must log in.
Revision history for this message
Zygmunt Krynicki (zyga) wrote :

Please create python3-checkbox-ng, checkbox-ng, and have c-c-s depend on checkbox-ng.

In the future all of our code (including Qt stuff most likely) will depend on checkbox-ng, not plainbox. I'd like to have all of the essential things oriented around that.

The c-c-s specific package can pull in dependency on proper providers, as you did, and it can also install a symlink (once we support that in plainbox) or the executable (as you did now, which is okay).

review: Needs Fixing
26. By Sylvain Pineau

debian:control: New canonical-certification-server binary package

27. By Sylvain Pineau

debian:rules: build/test/install checkbox-ng in debian/tmp

28. By Sylvain Pineau

debian:canonical-certification-server.install: Installation file

Just installing the canonical-certification-server command in /usr/bin

29. By Sylvain Pineau

debian:control: Added checkbox-ng and python3-checkbox-ng binaries

30. By Sylvain Pineau

debian: Added checkbox-ng and python3-checkbox-ng installation files

Revision history for this message
Sylvain Pineau (sylvain-pineau) wrote :

python3-checkbox-ng, checkbox-ng created and have c-c-s now depends on checkbox-ng.

review: Needs Resubmitting
Revision history for this message
Zygmunt Krynicki (zyga) wrote :

Thanks, +1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches