Checkbox

Merge lp://qastaging/~sylvain-pineau/checkbox/fix-1321225 into lp://qastaging/checkbox

fix-1321225
Merge into trunk

Proposed by Sylvain Pineau on 2014-05-28

Status:

Merged

Approved by:

Daniel Manrique on 2014-05-28

Approved revision:

3034

Merged at revision:

3036

Proposed branch:

lp://qastaging/~sylvain-pineau/checkbox/fix-1321225

Merge into:

lp://qastaging/checkbox

Diff against target:

12 lines (+1/-1)

1 file modified

checkbox-gui/gui-engine/gui-engine.cpp (+1/-1)

To merge this branch:

bzr merge lp://qastaging/~sylvain-pineau/checkbox/fix-1321225

High

Fix Released

Link a bug report

Reviewer	Review Type	Date Requested	Status
Daniel Manrique (community)		2014-05-28	Approve on 2014-05-28
Review via email: mp+221208@code.qastaging.launchpad.net

Description of the change

A workaround for the linked bug, preventing a job marked as failed when we resume a session to be rerun again.

Revision history for this message

Zygmunt Krynicki (zyga) wrote on 2014-05-28:

I suspect this is okay but I need to check it out in more detail. Other reviews are welcome!

Revision history for this message

Daniel Manrique (roadmr) wrote on 2014-05-28:

Looks OK to me, the logic is sound, I'm a bit scared of removing the element without first checking it's in the list, but removeOne seemingly fails gracefully in that case (returns false if element doesn't exist but we're not using return value here for anything).

review: Approve