Merge lp://qastaging/~sylvain-pineau/checkbox/fix-1323236 into lp://qastaging/checkbox
Proposed by
Sylvain Pineau
| Status: | Rejected |
|---|---|
| Rejected by: | Zygmunt Krynicki |
| Proposed branch: | lp://qastaging/~sylvain-pineau/checkbox/fix-1323236 |
| Merge into: | lp://qastaging/checkbox |
| Diff against target: |
12 lines (+1/-1) 1 file modified
plainbox/plainbox/impl/exporter/xlsx.py (+1/-1) |
| To merge this branch: | bzr merge lp://qastaging/~sylvain-pineau/checkbox/fix-1323236 |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Checkbox Developers | Pending | ||
|
Review via email:
|
|||
Description of the change
fix the linked bug, see commits for details
To post a comment you must log in.
Revision history for this message
| Zygmunt Krynicki (zyga) wrote | # |
Unmerged revisions
- 3034. By Sylvain Pineau
-
plainbox:
exporter: xlsx: fallback to the device path if no product is defined Some device information come from udev_resource and it may happen that the
device product is not available. Instead of returning an empty string,
fallback to the device path instead.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Sorry for rejecting this but I wrote an equivalent patch that is easier to read/maintain and I'd like to merge that one instead